From 533006c9b66475e906bcb4cb2824f994972be7e1 Mon Sep 17 00:00:00 2001
From: Mahesh Jethanandani <mjethanandani@gmail.com>
Date: Wed, 9 Jan 2019 16:46:26 -0800
Subject: [PATCH 1/3] Fix bug#96

---
 src/yang/etsi-nfv-ns.yang | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/src/yang/etsi-nfv-ns.yang b/src/yang/etsi-nfv-ns.yang
index 82d649e..d55215e 100644
--- a/src/yang/etsi-nfv-ns.yang
+++ b/src/yang/etsi-nfv-ns.yang
@@ -1479,6 +1479,16 @@ submodule etsi-nfv-ns {
                 "GS NFV IFA014: Section 6.2.8.2 MonitoringParameter
                  information element";
             }
+
+            leaf collection-period {
+              type string;
+              description
+                "An attribute that describes the periodicity at which
+                 to collect the performance information.";
+              reference
+                "GS NFV IFA014: Section 6.2.8.2 MonitoringParameter
+                 information element";
+            }
           }
 	}
       }
-- 
GitLab


From 851a4b3e45886728690da55bc886c25003582479 Mon Sep 17 00:00:00 2001
From: Mahesh Jethanandani <mjethanandani@gmail.com>
Date: Wed, 9 Jan 2019 18:09:30 -0800
Subject: [PATCH 2/3] Fix for bug#97

---
 src/yang/etsi-nfv-ns.yang | 46 +++++++++++++++++++++++++++++++--------
 1 file changed, 37 insertions(+), 9 deletions(-)

diff --git a/src/yang/etsi-nfv-ns.yang b/src/yang/etsi-nfv-ns.yang
index d55215e..1fef953 100644
--- a/src/yang/etsi-nfv-ns.yang
+++ b/src/yang/etsi-nfv-ns.yang
@@ -434,25 +434,53 @@ submodule etsi-nfv-ns {
           key "id";
 
           description
-            "A pool of descriptors of connection points attached to
-             one of the constituent VNFs and PNFs and/or one of the
-             SAPs of the parent NS or of a nested NS.";
+            "Describes a pool of descriptors of connection points
+             attached to one of the constituent VNFs and PNFs and/or
+             one of the SAPs of the parent NS or of a nested NS.";
           reference
             "GS NFV IFA014: Section 6.4.2.2 Vnffgd information
              element";
 
           leaf id {
             type string;
+          }
+
+          choice constituent-base-element-id {
+	    container vnf-profile {
+	      leaf vnf-profile-id {
+		must ". = deref(../../vnfd-profile-id)" {
+		}
+		type leafref {
+		  path "/nfv/nsd/df/vnf-profile/id";
+		}
+	      }
+	    }
+	    container pnf-profile {
+	      leaf pnf-profile-id {
+		must ". = deref(../../pnfd-profile-id)" {
+		}
+		type leafref {
+		  path "/nfv/nsd/df/pnf-profile/id";
+		}
+	      }
+	    }
+	    container ns-profile {
+	      leaf ns-profile-id {
+		must ". = deref(../../ns-profile-id)" {
+		}
+		type leafref {
+		  path "/nfv/nsd/df/ns-profile/id";
+		}
+	      }
+	    }
             description
-              "Identifier of this CpdPool information element. It
-               identifies a pool of descriptors of connection points
-               and NS SAPs.";
+              "Reference to the profile of an NS constituent.";
             reference
-              "GS NFV IFA014: Section 6.4.4.2 CpdPool information
-               element";
+              "GS NFV IFA014: Section 6.4.8 CpdInConstituentElement
+               information element";
           }
 
-          choice cpd-id {
+          choice constituent-cpd-id {
             container vnf {
               leaf vnfd-id {
                 must ". = deref(../../vnfd-profile-id)/../vnfd-id" {
-- 
GitLab


From c04eafecf8faddb9ca1fc0f9b2289258d3523d06 Mon Sep 17 00:00:00 2001
From: Mahesh Jethanandani <mjethanandani@gmail.com>
Date: Tue, 5 Feb 2019 16:41:47 -0800
Subject: [PATCH 3/3] added a missing mandatory statement

---
 src/yang/etsi-nfv-ns.yang | 53 ++++++++++++++++++++-------------------
 1 file changed, 27 insertions(+), 26 deletions(-)

diff --git a/src/yang/etsi-nfv-ns.yang b/src/yang/etsi-nfv-ns.yang
index 1fef953..8e77ebe 100644
--- a/src/yang/etsi-nfv-ns.yang
+++ b/src/yang/etsi-nfv-ns.yang
@@ -446,33 +446,34 @@ submodule etsi-nfv-ns {
           }
 
           choice constituent-base-element-id {
-	    container vnf-profile {
-	      leaf vnf-profile-id {
-		must ". = deref(../../vnfd-profile-id)" {
-		}
-		type leafref {
-		  path "/nfv/nsd/df/vnf-profile/id";
-		}
-	      }
-	    }
-	    container pnf-profile {
-	      leaf pnf-profile-id {
-		must ". = deref(../../pnfd-profile-id)" {
-		}
-		type leafref {
-		  path "/nfv/nsd/df/pnf-profile/id";
-		}
-	      }
-	    }
+            mandatory "true";
+            container vnf-profile {
+              leaf vnf-profile-id {
+                must ". = deref(../../vnfd-profile-id)" {
+                }
+                type leafref {
+                  path "/nfv/nsd/df/vnf-profile/id";
+                }
+              }
+            }
+            container pnf-profile {
+              leaf pnf-profile-id {
+                must ". = deref(../../pnfd-profile-id)" {
+                }
+                type leafref {
+                  path "/nfv/nsd/df/pnf-profile/id";
+                }
+              }
+            }
 	    container ns-profile {
-	      leaf ns-profile-id {
-		must ". = deref(../../ns-profile-id)" {
-		}
-		type leafref {
-		  path "/nfv/nsd/df/ns-profile/id";
-		}
-	      }
-	    }
+              leaf ns-profile-id {
+                must ". = deref(../../ns-profile-id)" {
+                }
+                type leafref {
+                  path "/nfv/nsd/df/ns-profile/id";
+                }
+              }
+            }
             description
               "Reference to the profile of an NS constituent.";
             reference
-- 
GitLab