From e75cb6a4bc77277ca6353b6dbb0abfae8d62c84d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pascal=20Sch=C3=A4fer?= Date: Wed, 24 May 2023 18:18:08 +0200 Subject: [PATCH 1/6] Add iP-nat-translated to iPAddress. --- 102232-1/LI-PS-PDU.asn | 2 ++ 1 file changed, 2 insertions(+) diff --git a/102232-1/LI-PS-PDU.asn b/102232-1/LI-PS-PDU.asn index 39b445b..894c3d5 100644 --- a/102232-1/LI-PS-PDU.asn +++ b/102232-1/LI-PS-PDU.asn @@ -713,6 +713,8 @@ IPAddress ::= SEQUENCE -- The subnet mask is intended to be presented as a binary value, e.g. "ff ff ff f8" to -- represent the dotted-decimal subnet mask of "255.255.255.248" corresponding to -- a /29 CIDR-format subnet mask + iP-nat-translated [6] BOOLEAN OPTIONAL + -- if absent, no translation (and backwards compat), if TRUE then NAT translated, if FALSE then explicit original in NAT. } IP-value ::= CHOICE -- GitLab From 15d63d54a9ff0648abc0845ecec1b24dcac88ca2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pascal=20Sch=C3=A4fer?= Date: Wed, 24 May 2023 18:21:25 +0200 Subject: [PATCH 2/6] Add comma to iPv4SubnetMask in iP-Address --- 102232-1/LI-PS-PDU.asn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/102232-1/LI-PS-PDU.asn b/102232-1/LI-PS-PDU.asn index 894c3d5..fbda121 100644 --- a/102232-1/LI-PS-PDU.asn +++ b/102232-1/LI-PS-PDU.asn @@ -708,7 +708,7 @@ IPAddress ::= SEQUENCE -- Indicates the length of the prefix delegated by the CSP to the subscriber -- example: 60 if IP address is "2001:db8:0:85a3::ac1f:8001/60" -- Mandatory in case where the iP-value contains an IPv6 binary value - iPv4SubnetMask [5] OCTET STRING (SIZE(4)) OPTIONAL + iPv4SubnetMask [5] OCTET STRING (SIZE(4)) OPTIONAL, -- For IPv4 addresses, this indicates the subnet mask to be applied to the iP-value field. -- The subnet mask is intended to be presented as a binary value, e.g. "ff ff ff f8" to -- represent the dotted-decimal subnet mask of "255.255.255.248" corresponding to -- GitLab From 99a674634a17658d45125ac2849b6ce951239ce1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pascal=20Sch=C3=A4fer?= Date: Wed, 31 May 2023 11:52:41 +0200 Subject: [PATCH 3/6] Clarify the meaning of backwards compatibility --- 102232-1/LI-PS-PDU.asn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/102232-1/LI-PS-PDU.asn b/102232-1/LI-PS-PDU.asn index fbda121..96acece 100644 --- a/102232-1/LI-PS-PDU.asn +++ b/102232-1/LI-PS-PDU.asn @@ -714,7 +714,7 @@ IPAddress ::= SEQUENCE -- represent the dotted-decimal subnet mask of "255.255.255.248" corresponding to -- a /29 CIDR-format subnet mask iP-nat-translated [6] BOOLEAN OPTIONAL - -- if absent, no translation (and backwards compat), if TRUE then NAT translated, if FALSE then explicit original in NAT. + -- if absent, no translation (i.e. it is may or may not translated for backwards compatibility), if TRUE then NAT translated, if FALSE then explicit original in NAT. } IP-value ::= CHOICE -- GitLab From 7eed8432db0c1f8f5a52bd1dc77ccfbb8536aebc Mon Sep 17 00:00:00 2001 From: canterburym Date: Wed, 31 May 2023 11:41:59 +0000 Subject: [PATCH 4/6] Reordering the comment to make it more clear. --- 102232-1/LI-PS-PDU.asn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/102232-1/LI-PS-PDU.asn b/102232-1/LI-PS-PDU.asn index 96acece..1c205c8 100644 --- a/102232-1/LI-PS-PDU.asn +++ b/102232-1/LI-PS-PDU.asn @@ -714,7 +714,7 @@ IPAddress ::= SEQUENCE -- represent the dotted-decimal subnet mask of "255.255.255.248" corresponding to -- a /29 CIDR-format subnet mask iP-nat-translated [6] BOOLEAN OPTIONAL - -- if absent, no translation (i.e. it is may or may not translated for backwards compatibility), if TRUE then NAT translated, if FALSE then explicit original in NAT. + -- If TRUE then NAT translated, if FALSE then explicit original in NAT. If absent, address may or may not be translated. } IP-value ::= CHOICE -- GitLab From 31030068652f801b1ea6c76c31c97048fea9cf8d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pascal=20Sch=C3=A4fer?= Date: Sat, 10 Jun 2023 02:10:38 +0200 Subject: [PATCH 5/6] Changed name and comment Changed the name from iP-nat-translated to iP-NAT-translated. Changed the comment to a multiline comment. --- 102232-1/LI-PS-PDU.asn | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/102232-1/LI-PS-PDU.asn b/102232-1/LI-PS-PDU.asn index 1c205c8..b69506c 100644 --- a/102232-1/LI-PS-PDU.asn +++ b/102232-1/LI-PS-PDU.asn @@ -713,8 +713,9 @@ IPAddress ::= SEQUENCE -- The subnet mask is intended to be presented as a binary value, e.g. "ff ff ff f8" to -- represent the dotted-decimal subnet mask of "255.255.255.248" corresponding to -- a /29 CIDR-format subnet mask - iP-nat-translated [6] BOOLEAN OPTIONAL - -- If TRUE then NAT translated, if FALSE then explicit original in NAT. If absent, address may or may not be translated. + iP-NAT-translated [6] BOOLEAN OPTIONAL + -- If TRUE then NAT translated, if FALSE then explicit original in NAT. + -- If absent, address may or may not be translated. } IP-value ::= CHOICE -- GitLab From 16258f1190cb763807e502545fb700c7c88306ef Mon Sep 17 00:00:00 2001 From: "wolf-joergen.stange" Date: Wed, 21 Jun 2023 12:29:47 +0200 Subject: [PATCH 6/6] Updated the comment to clarify what is meant. --- 102232-1/LI-PS-PDU.asn | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/102232-1/LI-PS-PDU.asn b/102232-1/LI-PS-PDU.asn index b69506c..3492b84 100644 --- a/102232-1/LI-PS-PDU.asn +++ b/102232-1/LI-PS-PDU.asn @@ -714,8 +714,8 @@ IPAddress ::= SEQUENCE -- represent the dotted-decimal subnet mask of "255.255.255.248" corresponding to -- a /29 CIDR-format subnet mask iP-NAT-translated [6] BOOLEAN OPTIONAL - -- If TRUE then NAT translated, if FALSE then explicit original in NAT. - -- If absent, address may or may not be translated. + -- If TRUE then NAT translated, if FALSE then not NAT translated. + -- If absent, IPAddress may or may not be NAT translated. } IP-value ::= CHOICE -- GitLab