Commit 37b518db authored by deshpande's avatar deshpande
Browse files

Made changes to possible problems in the code

parent 9a93a8df
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -38,7 +38,7 @@ module AtsNIT_SipSip_BC_TCFunctions {
	*  @desc The group structure is according to the TSS:
	*        
	*/
	group TP_1_BasicCall {
	group TP1_BasicCall {
		group TP1_1_BC_Successful {
			group TP1_1_1_BC_Normal_Call_Esthablishment {
				/* 
+75 −14
Original line number Diff line number Diff line
@@ -55,7 +55,7 @@
			map(p_imsComponent:SIPP, system:IMSCN1);		// Init test Configuration
			
			f_setVerdict(v_ret);
		}//end f_cf_2imsUp
		}//end f_cf_1imsUp
	
		/**
		 * @desc Creates test configuration of 2 IMS components
@@ -111,13 +111,52 @@
			//Map
			map(p_imsComponent1:SIPP, system:IMSCN1);		
			map(p_imsComponent2:SIPP, system:IMSCN2);		
			map(p_imsComponent2:SIPP, system:IMSCN3);
			map(p_imsComponent3:SIPP, system:IMSCN3);
			
			f_setVerdict(v_ret);
		}//end f_cf_3imsUp

		/**
		 * @desc Creates test configuration of 4 IMS components
		 * @param p_imsComponent1 first IMS component 
		 * @param p_imsComponent2 second IMS component 
		 * @param p_imsComponent3 third IMS component 
 		 * @param p_imsComponent4 fourth IMS component
		 */
		function f_cf_4imsUp(
			out ImsComponent p_imsComponent1, 
			out ImsComponent p_imsComponent2,
			out ImsComponent p_imsComponent3,
			out ImsComponent p_imsComponent4			
		)runs on ServerSyncComp {
			//Variables
			var FncRetCode v_ret := e_success;
			
			//Create
			p_imsComponent1 := ImsComponent.create;
			p_imsComponent2 := ImsComponent.create;
			p_imsComponent3 := ImsComponent.create;
			p_imsComponent4 := ImsComponent.create;
									
			//Connect
			connect(p_imsComponent1:syncPort, self:syncPort);
			connect(p_imsComponent2:syncPort, self:syncPort);
			connect(p_imsComponent3:syncPort, self:syncPort);
			connect(p_imsComponent4:syncPort, self:syncPort);
						
			//Map
			map(p_imsComponent1:SIPP, system:IMSCN1);		
			map(p_imsComponent2:SIPP, system:IMSCN2);		
			map(p_imsComponent3:SIPP, system:IMSCN3);
			map(p_imsComponent4:SIPP, system:IMSCN4);
						
			f_setVerdict(v_ret);			
		}//end f_cf_4imsUp

	}//end group cfUp
	
	group cfDown {
		
	 	/**
	     * @desc Deletes test configuration of 1 IMS component
	     * @param p_imsComponent IMS component
@@ -125,9 +164,6 @@
		function f_cf_1imsDown(
			in ImsComponent p_imsComponent
		) runs on ServerSyncComp {
			//Variables
			var FncRetCode v_ret := e_success;
			
			//Wait for clients 
			f_serverWaitForAllClientsToStop();
			
@@ -136,7 +172,7 @@

			//Unmap
			unmap(p_imsComponent:SIPP, system:IMSCN1);
		}//end f_cf_2imsDown
		}//end f_cf_1imsDown

		/**
		 * @desc Deletes test configuration of 2 IMS components
@@ -147,9 +183,6 @@
			in ImsComponent p_imsComponent1, 
			in ImsComponent p_imsComponent2
		) runs on ServerSyncComp {
			//Variables
			var FncRetCode v_ret := e_success;
			
			//Wait for clients 
			f_serverWaitForAllClientsToStop();
			
@@ -174,9 +207,33 @@
			in ImsComponent p_imsComponent2,
			in ImsComponent p_imsComponent3
		) runs on ServerSyncComp {
			//Variables
			var FncRetCode v_ret := e_success;
			//Wait for clients 
			f_serverWaitForAllClientsToStop();
			
			//Disconnect
			disconnect(p_imsComponent1:syncPort, self:syncPort);
			disconnect(p_imsComponent2:syncPort, self:syncPort);
			disconnect(p_imsComponent3:syncPort, self:syncPort);

			//Unmap
			unmap(p_imsComponent1:SIPP, system:IMSCN1);
			unmap(p_imsComponent2:SIPP, system:IMSCN2);
			unmap(p_imsComponent3:SIPP, system:IMSCN3);	
		}//end f_cf_3imsDown

		/**
		 * @desc Deletes test configuration of 4 IMS components
		 * @param p_imsComponent1 first IMS component
		 * @param p_imsComponent2 second IMS component
		 * @param p_imsComponent3 third IMS component
		 * @param p_imsComponent4 fourth IMS component
		 */
		function f_cf_4imsDown(
			in ImsComponent p_imsComponent1, 
			in ImsComponent p_imsComponent2,
			in ImsComponent p_imsComponent3,
			in ImsComponent p_imsComponent4
		) runs on ServerSyncComp {
			//Wait for clients 
			f_serverWaitForAllClientsToStop();
			
@@ -184,12 +241,16 @@
			disconnect(p_imsComponent1:syncPort, self:syncPort);
			disconnect(p_imsComponent2:syncPort, self:syncPort);
			disconnect(p_imsComponent3:syncPort, self:syncPort);
			disconnect(p_imsComponent4:syncPort, self:syncPort);
			
			//Unmap
			unmap(p_imsComponent1:SIPP, system:IMSCN1);
			unmap(p_imsComponent2:SIPP, system:IMSCN2);
			unmap(p_imsComponent2:SIPP, system:IMSCN3);	
		}//end f_cf_2imsDown
			unmap(p_imsComponent3:SIPP, system:IMSCN3);
			unmap(p_imsComponent4:SIPP, system:IMSCN4);
			
		}//end f_cf_4imsDown

	} //end group cfDown

} // end module AtsNIT_SipSip_TestConfiguration
 No newline at end of file
+1 −1
Original line number Diff line number Diff line
@@ -30,7 +30,7 @@
    			 * @desc The test system interface
    			 */
    			type component TestAdapter {
    				port SipPort IMSCN1, IMSCN2, IMSCN3;
    				port SipPort IMSCN1, IMSCN2, IMSCN3, IMSCN4;
    			}
    		} // end Group TestSystemInterfaces
    
+3255 −1023

File changed.

Preview size limit exceeded, changes collapsed.