Commit c7b41b43 authored by schulzs's avatar schulzs
Browse files

update based on code review

parent e344c556

LibIot/LibIot_Functions.ttcn

+5 −6
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ module LibIot_Functions { 
	group oracleFunctions {

    

    	/**

    	 * @desc sets the conformance verdict and send it to the test oracle

    	 * @desc Sets the conformance verdict on the oracle client and sends it to the oracle server

    	 * @param p_verdict conformance verdict set by the monitor

    	 * @param p_reason reason why the verdict has been set

    	 */
@@ -44,7 +44,7 @@ module LibIot_Functions { 
    	}

    

    	/**

    	* @desc sets the end-to-end verdict and send it to the test oracle

    	* @desc Sets the end-to-end verdict on the oracle client and sends it to the oracle server

    	* @param p_verdict e2e verdict set by the monitor

    	* @param p_reason reason why the verdict has been set

    	*/
@@ -56,7 +56,7 @@ module LibIot_Functions { 
    	}

    

    	/**

    	* @desc evaluate the test verdict and sets it correspondingly

    	* @desc Computes and logs overall verdict for end-to-end and conformance separately on oracle server

    	* @param p_verdict the verdict received

    	*/

    	function f_setIOTVerdict(in IOTVerdict p_verdict) runs on OracleServer {
@@ -71,7 +71,7 @@ module LibIot_Functions { 
    	

    	function f_logIOTVerdict(in IOTVerdict p_verdict) runs on OracleServer {

    		if (ischosen(p_verdict.e2e)) {

    			vc_e3e_verdicts[sizeof(vc_e3e_verdicts)] := p_verdict.e2e;

    			vc_e2e_verdicts[sizeof(vc_e2e_verdicts)] := p_verdict.e2e;

    			log("E2E verdict set to: ", p_verdict.e2e.verdict, "Reason: " & p_verdict.e2e.reason);

    		} else  {

    			vc_conf_verdicts[sizeof(vc_conf_verdicts)] := p_verdict.conformance;
@@ -81,8 +81,7 @@ module LibIot_Functions { 
    	

    

    	/**

    	* @desc listens continously on the port for receiving verdict 

    	* @param p_idx index of the port

    	* @desc Altstep to be used for listening continously on the verdict port of the oracle server for receiving verdicts from oracle clients

    	*/

    	altstep a_receiveIOTVerdict() runs on OracleServer {

    		var IOTVerdict v_verdict;

LibIot/LibIot_TestInterface.ttcn

+3 −3
Original line number Diff line number Diff line
@@ -68,7 +68,7 @@ module LibIot_TestInterface { 
		* @desc Configures the SUT or interconnecting network. Used as PTC.

		*/

		type component EutConfiguration extends OracleClient {

			port EutConfigPort dcPort;

			port EutConfigPort ecPort;



		}

	}// end group abstractTestComponents