Commit 9820ff05 authored by schulzs's avatar schulzs
Browse files

Updates based on code review

parent 10ce1c3a
Loading
Loading
Loading
Loading
+2 −2
Original line number Diff line number Diff line
@@ -88,9 +88,9 @@ module LibIot_Functions {
				[] tPort.getreply(Trigger:{-,-} value ?) -> value  v_status {
					if(ispresent(v_status.reason)) {
						v_reason := v_status.reason;
						f_setE2EVerdict(pass, "Trigger command successful: " & v_reason);
						f_setE2EVerdict(fail, "Trigger command unsuccessful: " & v_reason);
					}else {
						f_setE2EVerdict(pass, "Trigger command unsuccessful: no reason given");
						f_setE2EVerdict(fail, "Trigger command unsuccessful: no reason given");
					}
				}
				[] tPort.catch (timeout) {
+3 −2
Original line number Diff line number Diff line
@@ -8,9 +8,10 @@
module LibIot_PICS	 {
	
 	/**
	  * @desc boolean flag defines the overall verdict analysis.
	  * @desc PIXIT defines whcih verdict  (E2E or conformance)is to be kept track of with the TTCN-3 verdict.
	  *       Note that the verdict not chosen will be only available in log statements.
	  */
	modulepar boolean PX_CONFOMANCE_CHECK := false;
	modulepar IOTVerdictType PX_TTCN3_VERDICT := e_e2e;
	
	group numberOfComponents {
		modulepar {
+8 −1
Original line number Diff line number Diff line
@@ -11,6 +11,11 @@ module LibIot_TypesAndValues {

	}
	

	
	type enumerated IOTExecMode { e_realtime, e_offline }


	group triggerTypes {
		
		type record Status {
@@ -31,6 +36,8 @@ module LibIot_TypesAndValues {
		signature Trigger(TriggerCommand p_cmd, ParameterList p_params) return Status;
	}
	
	type enumerated IOTVerdictType { e_e2e, e_conformance } // TODO think about name

	type union IOTVerdict {
		verdicttype e2e,
		verdicttype conformance