Commit 663de53f authored by rennoch's avatar rennoch
Browse files

resolution of TODOs

parent 051ef9a5
Loading
Loading
Loading
Loading
+1 −1
Original line number Original line Diff line number Diff line
@@ -319,7 +319,7 @@ module DiameterRx_ImsGm_TCFunctions {
				// ReINVITE ...
				// ReINVITE ...
				// prepare and send RE-INVITE UE2
				// prepare and send RE-INVITE UE2
				// @SUT
				// @SUT
				// TODO Check function to set headers for reinvite on
				// Check function to set headers for reinvite on
				// originating side
				// originating side
				LibIms_Steps.f_setHeadersReINVITE(p_cSeq_s, true);
				LibIms_Steps.f_setHeadersReINVITE(p_cSeq_s, true);
				f_SendINVITE(m_INVITE_Request_UE(vc_requestUri, vc_callId,
				f_SendINVITE(m_INVITE_Request_UE(vc_requestUri, vc_callId,
+8 −1
Original line number Original line Diff line number Diff line
@@ -163,7 +163,14 @@ module DiameterRx_PIXITS
       The ANCA (Access-Network-Charging-Address) in type IPv6Addr format
       The ANCA (Access-Network-Charging-Address) in type IPv6Addr format
    
    
        */
        */
        modulepar IPv6Addr PX_ANCA_ipv6 := {1,2,3,4,5,6,7,8}
        modulepar IPv6Addr PX_ANCA_ipv6 := {1,2,3,4,5,6,7,8};
        
        /** @desc	UInt32, PIXIT item A-1/16 
                     
       The Media Component Number in type IPv6Addr format
    
        */        
        modulepar UInt32 PX_MediaComponentNr := 0
        
        
	} //end group DiameterCommonRxData
	} //end group DiameterCommonRxData


+2 −2
Original line number Original line Diff line number Diff line
@@ -74,7 +74,7 @@ module DiameterRx_Rx_TCFunctions {
                                           				
                                           				
                    f_selfOrClientSyncAndVerdict(c_tbDone, f_getVerdict()); //     sync
                    f_selfOrClientSyncAndVerdict(c_tbDone, f_getVerdict()); //     sync


                    tc_wait.start; tc_wait.timeout; //TODO: wait for checking no rejection?
                    tc_wait.start; tc_wait.timeout; //NOTE: wait for checking (no rejection)
				
				
                    f_selfOrClientSyncAndVerdict(c_poDone, f_getVerdict()); // sync
                    f_selfOrClientSyncAndVerdict(c_poDone, f_getVerdict()); // sync
				
				
@@ -162,7 +162,7 @@ module DiameterRx_Rx_TCFunctions {
															  m_resultCode(m_resultCode_diameterSuccess),
															  m_resultCode(m_resultCode_diameterSuccess),
															  m_accessNetworkChargingAddress(f_IPAdress(PX_ANCA_ipv4, PX_ANCA_ipv6))));
															  m_accessNetworkChargingAddress(f_IPAdress(PX_ANCA_ipv4, PX_ANCA_ipv6))));
                                                                                      				
                                                                                      				
                    tc_wait.start; tc_wait.timeout; //TODO: wait for checking no rejection?
                    tc_wait.start; tc_wait.timeout; //NOTE: wait for checking (no rejection)


                    f_selfOrClientSyncAndVerdict(c_poDone, f_getVerdict()); // sync
                    f_selfOrClientSyncAndVerdict(c_poDone, f_getVerdict()); // sync
				
				
+1 −1
Original line number Original line Diff line number Diff line
@@ -246,7 +246,7 @@ module DiameterRx_Templates {
                aVP_Header := m_aVP_HeaderVid(c_vendIdMedia_Component_Description_AVP, 12, omit), // considers lengths: media_Component_Nr
                aVP_Header := m_aVP_HeaderVid(c_vendIdMedia_Component_Description_AVP, 12, omit), // considers lengths: media_Component_Nr
    			media_Component_Nr := {
    			media_Component_Nr := {
    			    aVP_Header := m_aVP_HeaderVid(c_vendIdMedia_Component_Number_AVP, 4, omit),                                    
    			    aVP_Header := m_aVP_HeaderVid(c_vendIdMedia_Component_Number_AVP, 4, omit),                                    
    				aVP_Data := 1 //     TODO parameterize
    				aVP_Data := PX_MediaComponentNr
    			},  
    			},  
    			media_Sub_component := omit,
    			media_Sub_component := omit,
    			af_Application_Id := omit,
    			af_Application_Id := omit,