Commit fbd3e06b authored by Richard Levitte's avatar Richard Levitte
Browse files

Fix cipher_compare 



Unsigned overflow.  Found by Brian Carpenter

Fixes #3889

Reviewed-by: default avatarTim Hudson <tjh@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/3890)

(cherry picked from commit a7ff5796)
parent 64903a26

ssl/s3_lib.c

+3 −1
Original line number Diff line number Diff line
@@ -2725,7 +2725,9 @@ static int cipher_compare(const void *a, const void *b) 
    const SSL_CIPHER *ap = (const SSL_CIPHER *)a;

    const SSL_CIPHER *bp = (const SSL_CIPHER *)b;



    return ap->id - bp->id;

    if (ap->id == bp->id)

        return 0;

    return ap->id < bp->id ? -1 : 1;

}



void ssl_sort_cipher_list(void)