Commit f2ce14d6 authored by Pauli's avatar Pauli
Browse files

Check the return from BN_sub() in BN_X931_generate_Xpq(). 



Reviewed-by: default avatarTim Hudson <tjh@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/7088)

(cherry picked from commit 6bcfcf16)
parent dfbc526e

crypto/bn/bn_x931p.c

+3 −1
Original line number Diff line number Diff line
@@ -184,8 +184,10 @@ int BN_X931_generate_Xpq(BIGNUM *Xp, BIGNUM *Xq, int nbits, BN_CTX *ctx) 
    for (i = 0; i < 1000; i++) {

        if (!BN_rand(Xq, nbits, BN_RAND_TOP_TWO, BN_RAND_BOTTOM_ANY))

            goto err;



        /* Check that |Xp - Xq| > 2^(nbits - 100) */

        BN_sub(t, Xp, Xq);

        if (!BN_sub(t, Xp, Xq))

            goto err;

        if (BN_num_bits(t) > (nbits - 100))

            break;

    }