Commit df2ee0e2 authored by Ben Laurie's avatar Ben Laurie
Browse files

Enable -Wmissing-variable-declarations and 


-Wincompatible-pointer-types-discards-qualifiers (the latter did not require
any code changes).

Reviewed-by: default avatarRich Salz <rsalz@openssl.org>
parent 4c7103a5

Configure

+2 −3
Original line number Diff line number Diff line
@@ -103,11 +103,10 @@ my $gcc_devteam_warn = "-Wall -pedantic -DPEDANTIC -Wno-long-long -Wsign-compare 
# TODO(openssl-team): fix problems and investigate if (at least) the

# following warnings can also be enabled:

# -Wswitch-enum, -Wunused-macros, -Wmissing-field-initializers,

# -Wmissing-variable-declarations,

# -Wincompatible-pointer-types-discards-qualifiers, -Wcast-align,

# -Wcast-align,

# -Wunreachable-code -Wunused-parameter -Wlanguage-extension-token

# -Wextended-offsetof

my $clang_devteam_warn = "-Wno-unused-parameter -Wno-missing-field-initializers -Wno-language-extension-token -Wno-extended-offsetof -Wconditional-uninitialized -Qunused-arguments";

my $clang_devteam_warn = "-Wno-unused-parameter -Wno-missing-field-initializers -Wno-language-extension-token -Wno-extended-offsetof -Wconditional-uninitialized -Qunused-arguments -Wincompatible-pointer-types-discards-qualifiers -Wmissing-variable-declarations";



my $strict_warnings = 0;

apps/apps.h

+6 −0
Original line number Diff line number Diff line
@@ -573,6 +573,12 @@ int raw_write_stdout(const void *, int); 
# define TM_STOP         1

double app_tminterval(int stop, int usertime);



/* this is an accident waiting to happen (-Wshadow is your friend) */

extern int verify_depth;

extern int verify_quiet;

extern int verify_error;

extern int verify_return_error;



# include "progs.h"



#endif

apps/cms.c

+1 −1
Original line number Diff line number Diff line
@@ -95,7 +95,7 @@ static int cms_set_pkey_param(EVP_PKEY_CTX *pctx, 
# define SMIME_SIGN_RECEIPT      (15 | SMIME_IP | SMIME_OP)

# define SMIME_VERIFY_RECEIPT    (16 | SMIME_IP)



int verify_err = 0;

static int verify_err = 0;



typedef struct cms_key_param_st cms_key_param;

apps/ecparam.c

+2 −2
Original line number Diff line number Diff line
@@ -116,14 +116,14 @@ OPTIONS ecparam_options[] = { 
    {NULL}

};



OPT_PAIR forms[] = {

static OPT_PAIR forms[] = {

    {"compressed", POINT_CONVERSION_COMPRESSED},

    {"uncompressed", POINT_CONVERSION_UNCOMPRESSED},

    {"hybrid", POINT_CONVERSION_HYBRID},

    {NULL}

};



OPT_PAIR encodings[] = {

static OPT_PAIR encodings[] = {

    {"named_curve", OPENSSL_EC_NAMED_CURVE},

    {"explicit", 0},

    {NULL}

apps/openssl.c

+1 −1
Original line number Diff line number Diff line
@@ -160,7 +160,7 @@ static void list_pkey(void); 
static void list_type(FUNC_TYPE ft);

char *default_config_file = NULL;



CONF *config = NULL;

static CONF *config = NULL;

BIO *bio_in = NULL;

BIO *bio_out = NULL;

BIO *bio_err = NULL;