Commit d875413a authored by Bodo Möller's avatar Bodo Möller
Browse files

Make sure that SSL_OP_NETSCAPE_REUSE_CIPHER_CHANGE_BUG can't 

enable disabled ciphersuites.
parent 155ad6d2

CHANGES

+6 −1
Original line number Diff line number Diff line
@@ -4,7 +4,12 @@ 


 Changes between 0.9.8i and 0.9.8j  [xx XXX xxxx]



  *)

  *) Change the server-side SSL_OP_NETSCAPE_REUSE_CIPHER_CHANGE_BUG behavior

     to ensure that even with this option, only ciphersuites in the

     server's preference list will be accepted.  (Note that the option

     applies only when resuming a session, so the earlier behavior was

     just about the algorithm choice for symmetric cryptography.)

     [Bodo Moeller]



 Changes between 0.9.8h and 0.9.8i  [15 Sep 2008]

ssl/s3_srvr.c

+19 −13
Original line number Diff line number Diff line
@@ -902,14 +902,21 @@ int ssl3_get_client_hello(SSL *s) 
				break;

				}

			}

		if (j == 0)

		if (j == 0 && (s->options & SSL_OP_NETSCAPE_REUSE_CIPHER_CHANGE_BUG) && (sk_SSL_CIPHER_num(ciphers) == 1))

			{

			if ((s->options & SSL_OP_NETSCAPE_REUSE_CIPHER_CHANGE_BUG) && (sk_SSL_CIPHER_num(ciphers) == 1))

			/* Special case as client bug workaround: the previously used cipher may

			 * not be in the current list, the client instead might be trying to

			 * continue using a cipher that before wasn't chosen due to server

			 * preferences.  We'll have to reject the connection if the cipher is not

			 * enabled, though. */

			c = sk_SSL_CIPHER_value(ciphers, 0);

			if (sk_SSL_CIPHER_find(SSL_get_ciphers(s), c) >= 0)

				{

				/* Very bad for multi-threading.... */

				s->session->cipher=sk_SSL_CIPHER_value(ciphers, 0);

				s->session->cipher = c;

				j = 1;

				}

			else

			}

		if (j == 0)

			{

			/* we need to have the cipher in the cipher

			 * list if we are asked to reuse it */
@@ -918,7 +925,6 @@ int ssl3_get_client_hello(SSL *s) 
			goto f_err;

			}

		}

		}



	/* compression */

	i= *(p++);