Commit c61f0cbf authored by Dr. Stephen Henson's avatar Dr. Stephen Henson
Browse files

Fix free errors in ocsp utility. 

Keep copy of any host, path and port values allocated by
OCSP_parse_url and free as necessary.
(cherry picked from commit 5219d3dd)
parent d90605dd

apps/ocsp.c

+16 −6
Original line number Diff line number Diff line
@@ -98,6 +98,7 @@ int MAIN(int argc, char **argv) 
	ENGINE *e = NULL;

	char **args;

	char *host = NULL, *port = NULL, *path = "/";

	char *thost = NULL, *tport = NULL, *tpath = NULL;

	char *reqin = NULL, *respin = NULL;

	char *reqout = NULL, *respout = NULL;

	char *signfile = NULL, *keyfile = NULL;
@@ -173,6 +174,12 @@ int MAIN(int argc, char **argv) 
			}

		else if (!strcmp(*args, "-url"))

			{

			if (thost)

				OPENSSL_free(thost);

			if (tport)

				OPENSSL_free(tport);

			if (tpath)

				OPENSSL_free(tpath);

			if (args[1])

				{

				args++;
@@ -181,6 +188,9 @@ int MAIN(int argc, char **argv) 
					BIO_printf(bio_err, "Error parsing URL\n");

					badarg = 1;

					}

				thost = host;

				tport = port;

				tpath = path;

				}

			else badarg = 1;

			}
@@ -871,12 +881,12 @@ end: 
	sk_X509_pop_free(sign_other, X509_free);

	sk_X509_pop_free(verify_other, X509_free);



	if (use_ssl != -1)

		{

		OPENSSL_free(host);

		OPENSSL_free(port);

		OPENSSL_free(path);

		}

	if (thost)

		OPENSSL_free(thost);

	if (tport)

		OPENSSL_free(tport);

	if (tpath)

		OPENSSL_free(tpath);



	OPENSSL_EXIT(ret);

}