Commit c5b0f5c4 authored by Dr. Stephen Henson's avatar Dr. Stephen Henson
Browse files

Don't set *pval to NULL in ASN1_item_ex_new. 



While *pval is usually a pointer in rare circumstances it can be a long
value. One some platforms (e.g. WIN64) where
sizeof(long) < sizeof(ASN1_VALUE *) this will write past the field.

*pval is initialised correctly in the rest of ASN1_item_ex_new so setting it
to NULL is unecessary anyway.

Thanks to Julien Kauffmann for reporting this issue.

Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
(cherry picked from commit f617b496)

Conflicts:
	crypto/asn1/tasn_new.c
parent 32fbe914

crypto/asn1/tasn_new.c

+0 −3
Original line number Diff line number Diff line
@@ -100,9 +100,6 @@ static int asn1_item_ex_combine_new(ASN1_VALUE **pval, const ASN1_ITEM *it, 
    else

        asn1_cb = 0;



    if (!combine)

        *pval = NULL;



#ifdef CRYPTO_MDEBUG

    if (it->sname)

        CRYPTO_push_info(it->sname);