Commit c2319cf9 authored by Alessandro Ghedini's avatar Alessandro Ghedini Committed by Richard Levitte
Browse files

Set salt length after the malloc has succeeded 



Reviewed-by: default avatarRich Salz <rsalz@openssl.org>
Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
parent 3f6c7691

crypto/pkcs12/p12_mutl.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -208,11 +208,11 @@ int PKCS12_setup_mac(PKCS12 *p12, int iter, unsigned char *salt, int saltlen, 
    }

    }

    if (!saltlen)

    if (!saltlen)

        saltlen = PKCS12_SALT_LEN;

        saltlen = PKCS12_SALT_LEN;

    p12->mac->salt->length = saltlen;

    if ((p12->mac->salt->data = OPENSSL_malloc(saltlen)) == NULL) {

    if ((p12->mac->salt->data = OPENSSL_malloc(saltlen)) == NULL) {

        PKCS12err(PKCS12_F_PKCS12_SETUP_MAC, ERR_R_MALLOC_FAILURE);

        PKCS12err(PKCS12_F_PKCS12_SETUP_MAC, ERR_R_MALLOC_FAILURE);

        return 0;

        return 0;

    }

    }

    p12->mac->salt->length = saltlen;

    if (!salt) {

    if (!salt) {

        if (RAND_bytes(p12->mac->salt->data, saltlen) <= 0)

        if (RAND_bytes(p12->mac->salt->data, saltlen) <= 0)

            return 0;

            return 0;