Commit aa388af1 authored by Dr. Stephen Henson's avatar Dr. Stephen Henson
Browse files

Remove unnecessary check. 



The overflow check will never be triggered because the
the n2l3 result is always less than 2^24.

Reviewed-by: default avatarMatt Caswell <matt@openssl.org>
(cherry picked from commit 709ec8b3)
parent 52e623c4

ssl/s3_both.c

+0 −5
Original line number Diff line number Diff line
@@ -497,11 +497,6 @@ long ssl3_get_message(SSL *s, int st1, int stn, int mt, long max, int *ok) 
            SSLerr(SSL_F_SSL3_GET_MESSAGE, SSL_R_EXCESSIVE_MESSAGE_SIZE);

            goto f_err;

        }

        if (l > (INT_MAX - 4)) { /* BUF_MEM_grow takes an 'int' parameter */

            al = SSL_AD_ILLEGAL_PARAMETER;

            SSLerr(SSL_F_SSL3_GET_MESSAGE, SSL_R_EXCESSIVE_MESSAGE_SIZE);

            goto f_err;

        }

        if (l && !BUF_MEM_grow_clean(s->init_buf, (int)l + 4)) {

            SSLerr(SSL_F_SSL3_GET_MESSAGE, ERR_R_BUF_LIB);

            goto err;