Commit a677c87b authored by Dr. Stephen Henson's avatar Dr. Stephen Henson
Browse files

Since FIPS 186-3 specifies we use the leftmost bits of the digest 

we shouldn't reject digest lengths larger than SHA256: the FIPS
algorithm tests include SHA384 and SHA512 tests.
parent f8a123b4

crypto/dsa/dsa_ossl.c

+0 −18
Original line number Diff line number Diff line
@@ -148,15 +148,6 @@ static DSA_SIG *dsa_do_sign(const unsigned char *dgst, int dlen, DSA *dsa) 


	s=BN_new();

	if (s == NULL) goto err;



	/* reject a excessive digest length (currently at most

	 * dsa-with-SHA256 is supported) */

	if (dlen > SHA256_DIGEST_LENGTH)

		{

		reason=DSA_R_DATA_TOO_LARGE_FOR_KEY_SIZE;

		goto err;

		}



	ctx=BN_CTX_new();

	if (ctx == NULL) goto err;
@@ -325,15 +316,6 @@ static int dsa_do_verify(const unsigned char *dgst, int dgst_len, DSA_SIG *sig, 
		DSAerr(DSA_F_DSA_DO_VERIFY,DSA_R_MODULUS_TOO_LARGE);

		return -1;

		}



	/* reject a excessive digest length (currently at most

	 * dsa-with-SHA256 is supported) */

	if (dgst_len > SHA256_DIGEST_LENGTH)

		{

		DSAerr(DSA_F_DSA_DO_VERIFY,DSA_R_DATA_TOO_LARGE_FOR_KEY_SIZE);

		return -1;

		}



	BN_init(&u1);

	BN_init(&u2);

	BN_init(&t1);