Commit a033c3c7 authored by Dr. Stephen Henson's avatar Dr. Stephen Henson
Browse files

PR: 2250 

Submitted By: Ger Hobbelt <ger@hobbelt.com>

Don't overwrite return value with strlen(f).
parent 359b0c9f

crypto/x509/x509_cmp.c

+1 −2
Original line number Diff line number Diff line
@@ -86,10 +86,9 @@ unsigned long X509_issuer_and_serial_hash(X509 *a) 


	EVP_MD_CTX_init(&ctx);

	f=X509_NAME_oneline(a->cert_info->issuer,NULL,0);

	ret=strlen(f);

	if (!EVP_DigestInit_ex(&ctx, EVP_md5(), NULL))

		goto err;

	if (!EVP_DigestUpdate(&ctx,(unsigned char *)f,ret))

	if (!EVP_DigestUpdate(&ctx,(unsigned char *)f,strlen(f)))

		goto err;

	OPENSSL_free(f);

	if(!EVP_DigestUpdate(&ctx,(unsigned char *)a->cert_info->serialNumber->data,