Commit 9fbbdd73 authored by Andy Polyakov's avatar Andy Polyakov Committed by Kurt Roeckx
Browse files

Avoid reading an unused byte after the buffer 



Other curves don't have this problem.

Reviewed-by: default avatarKurt Roeckx <kurt@roeckx.be>
Reviewed-by: default avatarEmilia Käsper <emilia@openssl.org>
parent 8b37e5c1

crypto/ec/ecp_nistp224.c

+1 −1
Original line number Diff line number Diff line
@@ -316,7 +316,7 @@ static void bin28_to_felem(felem out, const u8 in[28]) 
    out[0] = *((const uint64_t *)(in)) & 0x00ffffffffffffff;

    out[1] = (*((const uint64_t *)(in + 7))) & 0x00ffffffffffffff;

    out[2] = (*((const uint64_t *)(in + 14))) & 0x00ffffffffffffff;

    out[3] = (*((const uint64_t *)(in + 21))) & 0x00ffffffffffffff;

    out[3] = (*((const uint64_t *)(in+20))) >> 8;

}



static void felem_to_bin28(u8 out[28], const felem in)