Commit 924212a6 authored by FdaSilvaYY's avatar FdaSilvaYY Committed by Richard Levitte
Browse files

Constify input buffer 



 of X509_NAME_add_entry_by_OBJ, X509_NAME_add_entry_by_NID, X509_NAME_ENTRY_create_by_NID

Reviewed-by: default avatarRich Salz <rsalz@openssl.org>
Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
parent 69b017f6

crypto/x509/x509name.c

+4 −3
Original line number Diff line number Diff line
@@ -131,7 +131,7 @@ X509_NAME_ENTRY *X509_NAME_delete_entry(X509_NAME *name, int loc) 
}



int X509_NAME_add_entry_by_OBJ(X509_NAME *name, const ASN1_OBJECT *obj, int type,

                               unsigned char *bytes, int len, int loc,

                               const unsigned char *bytes, int len, int loc,

                               int set)

{

    X509_NAME_ENTRY *ne;
@@ -145,7 +145,7 @@ int X509_NAME_add_entry_by_OBJ(X509_NAME *name, const ASN1_OBJECT *obj, int type 
}



int X509_NAME_add_entry_by_NID(X509_NAME *name, int nid, int type,

                               unsigned char *bytes, int len, int loc,

                               const unsigned char *bytes, int len, int loc,

                               int set)

{

    X509_NAME_ENTRY *ne;
@@ -253,7 +253,8 @@ X509_NAME_ENTRY *X509_NAME_ENTRY_create_by_txt(X509_NAME_ENTRY **ne, 
}



X509_NAME_ENTRY *X509_NAME_ENTRY_create_by_NID(X509_NAME_ENTRY **ne, int nid,

                                               int type, unsigned char *bytes,

                                               int type,

                                               const unsigned char *bytes,

                                               int len)

{

    ASN1_OBJECT *obj;

doc/crypto/X509_NAME_ENTRY_get_object.pod

+1 −1
Original line number Diff line number Diff line
@@ -18,7 +18,7 @@ X509_NAME_ENTRY_create_by_OBJ - X509_NAME_ENTRY utility functions 
 int X509_NAME_ENTRY_set_data(X509_NAME_ENTRY *ne, int type, const unsigned char *bytes, int len);



 X509_NAME_ENTRY *X509_NAME_ENTRY_create_by_txt(X509_NAME_ENTRY **ne, const char *field, int type, const unsigned char *bytes, int len);

 X509_NAME_ENTRY *X509_NAME_ENTRY_create_by_NID(X509_NAME_ENTRY **ne, int nid, int type, unsigned char *bytes, int len);

 X509_NAME_ENTRY *X509_NAME_ENTRY_create_by_NID(X509_NAME_ENTRY **ne, int nid, int type, const unsigned char *bytes, int len);

 X509_NAME_ENTRY *X509_NAME_ENTRY_create_by_OBJ(X509_NAME_ENTRY **ne, const ASN1_OBJECT *obj, int type, const unsigned char *bytes, int len);



=head1 DESCRIPTION

doc/crypto/X509_NAME_add_entry_by_txt.pod

+2 −2
Original line number Diff line number Diff line
@@ -11,9 +11,9 @@ X509_NAME_add_entry, X509_NAME_delete_entry - X509_NAME modification functions 


 int X509_NAME_add_entry_by_txt(X509_NAME *name, const char *field, int type, const unsigned char *bytes, int len, int loc, int set);



 int X509_NAME_add_entry_by_OBJ(X509_NAME *name, const ASN1_OBJECT *obj, int type, unsigned char *bytes, int len, int loc, int set);

 int X509_NAME_add_entry_by_OBJ(X509_NAME *name, const ASN1_OBJECT *obj, int type, const unsigned char *bytes, int len, int loc, int set);



 int X509_NAME_add_entry_by_NID(X509_NAME *name, int nid, int type, unsigned char *bytes, int len, int loc, int set);

 int X509_NAME_add_entry_by_NID(X509_NAME *name, int nid, int type, const unsigned char *bytes, int len, int loc, int set);



 int X509_NAME_add_entry(X509_NAME *name, X509_NAME_ENTRY *ne, int loc, int set);

include/openssl/x509.h

+4 −3
Original line number Diff line number Diff line
@@ -771,17 +771,18 @@ X509_NAME_ENTRY *X509_NAME_delete_entry(X509_NAME *name, int loc); 
int X509_NAME_add_entry(X509_NAME *name, X509_NAME_ENTRY *ne,

                        int loc, int set);

int X509_NAME_add_entry_by_OBJ(X509_NAME *name, const ASN1_OBJECT *obj, int type,

                               unsigned char *bytes, int len, int loc,

                               const unsigned char *bytes, int len, int loc,

                               int set);

int X509_NAME_add_entry_by_NID(X509_NAME *name, int nid, int type,

                               unsigned char *bytes, int len, int loc,

                               const unsigned char *bytes, int len, int loc,

                               int set);

X509_NAME_ENTRY *X509_NAME_ENTRY_create_by_txt(X509_NAME_ENTRY **ne,

                                               const char *field, int type,

                                               const unsigned char *bytes,

                                               int len);

X509_NAME_ENTRY *X509_NAME_ENTRY_create_by_NID(X509_NAME_ENTRY **ne, int nid,

                                               int type, unsigned char *bytes,

                                               int type, 

                                               const unsigned char *bytes,

                                               int len);

int X509_NAME_add_entry_by_txt(X509_NAME *name, const char *field, int type,

                               const unsigned char *bytes, int len, int loc,