Commit 8fbb93d0 authored Mar 04, 2016 by Rob Percival Committed by Rich Salz Mar 09, 2016

Makes SCT_LIST_set_source return the number of successes



No longer terminates on first error, but instead tries to set the source
of every SCT regardless of whether an error occurs with some.

Reviewed-by: Emilia Käsper <emilia@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>

parent aeb5b955

crypto/ct/ct_sct.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -317,12 +317,11 @@ int SCT_set_source(SCT *sct, sct_source_t source)

		int SCT_LIST_set_source(const STACK_OF(SCT) *scts, sct_source_t source)
		{
		int i, ret = 1;
		int i, ret = 0;

		for (i = 0; i < sk_SCT_num(scts); ++i) {
		ret = SCT_set_source(sk_SCT_value(scts, i), source);
		if (ret != 1)
		break;
		if (SCT_set_source(sk_SCT_value(scts, i), source))
		++ret;
		}

		return ret;

include/openssl/ct.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -305,7 +305,7 @@ int SCT_set_source(SCT *sct, sct_source_t source);

		/*
		* Sets the source of all of the SCTs to the same value.
		* Returns 1 on success.
		* Returns the number of SCTs whose source was set successfully.
		*/
		int SCT_LIST_set_source(const STACK_OF(SCT) *scts, sct_source_t source);