Commit 7ca3ea22 authored by TJ Saunders's avatar TJ Saunders Committed by Rich Salz
Browse files

Reorder the setter arguments to more consistently match that of other APIs, 


per review comments.

Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
Reviewed-by: default avatarEmilia Käsper <emilia@openssl.org>
Reviewed-by: default avatarRich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/1193)
parent 6a571a18

crypto/dsa/dsa_asn1.c

+1 −1
Original line number Diff line number Diff line
@@ -32,7 +32,7 @@ void DSA_SIG_get0(BIGNUM **pr, BIGNUM **ps, const DSA_SIG *sig) 
    *ps = sig->s;

}



int DSA_SIG_set0(BIGNUM *r, BIGNUM *s, DSA_SIG *sig)

int DSA_SIG_set0(DSA_SIG *sig, BIGNUM *r, BIGNUM *s)

{

    BN_clear_free(sig->r);

    BN_clear_free(sig->s);

crypto/ec/ec_asn1.c

+1 −1
Original line number Diff line number Diff line
@@ -1180,7 +1180,7 @@ void ECDSA_SIG_get0(BIGNUM **pr, BIGNUM **ps, const ECDSA_SIG *sig) 
        *ps = sig->s;

}



int ECDSA_SIG_set0(BIGNUM *r, BIGNUM *s, ECDSA_SIG *sig)

int ECDSA_SIG_set0(ECDSA_SIG *sig, BIGNUM *r, BIGNUM *s)

{

    BN_clear_free(sig->r);

    BN_clear_free(sig->s);

doc/crypto/DSA_SIG_new.pod

+1 −1
Original line number Diff line number Diff line
@@ -11,7 +11,7 @@ DSA_SIG_new, DSA_SIG_free - allocate and free DSA signature objects 
 DSA_SIG *DSA_SIG_new(void);

 void DSA_SIG_free(DSA_SIG *a);

 void DSA_SIG_get0(BIGNUM **pr, BIGNUM **ps, const DSA_SIG *sig);

 int DSA_SIG_set0(BIGNUM *r, BIGNUM *s, DSA_SIG *sig);

 int DSA_SIG_set0(DSA_SIG *sig, BIGNUM *r, BIGNUM *s);



=head1 DESCRIPTION

doc/crypto/ECDSA_SIG_new.pod

+1 −1
Original line number Diff line number Diff line
@@ -14,7 +14,7 @@ algorithm (ECDSA) functions 
 ECDSA_SIG *ECDSA_SIG_new(void);

 void ECDSA_SIG_free(ECDSA_SIG *sig);

 void ECDSA_SIG_get0(BIGNUM **pr, BIGNUM **ps, const ECDSA_SIG *sig);

 int ECDSA_SIG_set0(BIGNUM *r, BIGNUM *s, ECDSA_SIG *sig);

 int ECDSA_SIG_set0(ECDSA_SIG *sig, BIGNUM *r, BIGNUM *s);

 int i2d_ECDSA_SIG(const ECDSA_SIG *sig, unsigned char **pp);

 ECDSA_SIG *d2i_ECDSA_SIG(ECDSA_SIG **sig, const unsigned char **pp, long len);

 int ECDSA_size(const EC_KEY *eckey);