Commit 71d8c138 authored by Bernd Edlinger's avatar Bernd Edlinger Committed by Rich Salz
Browse files

Fix a memleak in tls13_generate_secret. 



Reviewed-by: default avatarMatt Caswell <matt@openssl.org>
Reviewed-by: default avatarRich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/3660)
parent 5816586b

ssl/tls13_enc.c

+4 −1
Original line number Diff line number Diff line
@@ -148,6 +148,7 @@ int tls13_generate_secret(SSL *s, const EVP_MD *md, 
                || EVP_DigestInit_ex(mctx, md, NULL) <= 0

                || EVP_DigestFinal_ex(mctx, hash, NULL) <= 0) {

            EVP_MD_CTX_free(mctx);

            EVP_PKEY_CTX_free(pctx);

            return 0;

        }

        EVP_MD_CTX_free(mctx);
@@ -156,8 +157,10 @@ int tls13_generate_secret(SSL *s, const EVP_MD *md, 
        if (!tls13_hkdf_expand(s, md, prevsecret,

                               (unsigned char *)derived_secret_label,

                               sizeof(derived_secret_label) - 1, hash,

                               preextractsec, mdlen))

                               preextractsec, mdlen)) {

            EVP_PKEY_CTX_free(pctx);

            return 0;

        }



        prevsecret = preextractsec;

        prevsecretlen = mdlen;