Commit 69567687 authored by Andy Polyakov's avatar Andy Polyakov
Browse files

bn/asm/x86_64-mont5.pl: fix valgrind error. 



bn_get_bits5 was overstepping array boundary by 1 byte. It was exclusively
read overstep and data could not have been used. The only potential problem
would be if array happens to end on the very edge of last accesible page.

Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
parent 86e5d1e3

crypto/bn/asm/x86_64-mont5.pl

+9 −4
Original line number Diff line number Diff line
@@ -3231,11 +3231,16 @@ $code.=<<___; 
.type	bn_get_bits5,\@abi-omnipotent

.align	16

bn_get_bits5:

	mov	$inp,%r10

	lea	0($inp),%r10

	lea	1($inp),%r11

	mov	$num,%ecx

	shr	\$3,$num

	movzw	(%r10,$num),%eax

	and	\$7,%ecx

	shr	\$4,$num

	and	\$15,%ecx

	lea	-8(%ecx),%eax

	cmp	\$11,%ecx

	cmova	%r11,%r10

	cmova	%eax,%ecx

	movzw	(%r10,$num,2),%eax

	shrl	%cl,%eax

	and	\$31,%eax

	ret