Commit 68ad17e8 authored by Pauli's avatar Pauli
Browse files

Check for negative return for signature size.Addresses Coverity 1442933 



Reviewed-by: default avatarMatt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/8392)
parent 38023b87

test/ecdsatest.c

+4 −2
Original line number Original line Diff line number Diff line
@@ -205,6 +205,7 @@ static int test_builtin(int n) 
    EVP_MD_CTX *mctx = NULL;

    EVP_MD_CTX *mctx = NULL;

    size_t sig_len;

    size_t sig_len;

    int nid, ret = 0;

    int nid, ret = 0;

    int temp;





    nid = curves[n].nid;

    nid = curves[n].nid;
@@ -231,9 +232,10 @@ static int test_builtin(int n) 
        || !TEST_true(EVP_PKEY_assign_EC_KEY(pkey_neg, eckey_neg)))

        || !TEST_true(EVP_PKEY_assign_EC_KEY(pkey_neg, eckey_neg)))

        goto err;

        goto err;





    sig_len = ECDSA_size(eckey);

    temp = ECDSA_size(eckey);





    if (!TEST_ptr(sig = OPENSSL_malloc(sig_len))

    if (!TEST_int_ge(temp, 0)

        || !TEST_ptr(sig = OPENSSL_malloc(sig_len = (size_t)temp))

        /* create a signature */

        /* create a signature */

        || !TEST_true(EVP_DigestSignInit(mctx, NULL, NULL, NULL, pkey))

        || !TEST_true(EVP_DigestSignInit(mctx, NULL, NULL, NULL, pkey))

        || !TEST_true(EVP_DigestSign(mctx, sig, &sig_len, tbs, sizeof(tbs)))

        || !TEST_true(EVP_DigestSign(mctx, sig, &sig_len, tbs, sizeof(tbs)))