Commit 67b6f1ca authored by Nils Larsch's avatar Nils Larsch
Browse files

fix problems found by coverity: remove useless code

parent a4ff3925

apps/apps.c

+0 −3
Original line number Diff line number Diff line
@@ -1734,10 +1734,7 @@ CA_DB *load_index(char *dbfile, DB_ATTR *db_attr) 
		goto err;

		}

	if ((tmpdb = TXT_DB_read(in,DB_NUMBER)) == NULL)

		{

		if (tmpdb != NULL) TXT_DB_free(tmpdb);

		goto err;

		}



#ifndef OPENSSL_SYS_VMS

	BIO_snprintf(buf[0], sizeof buf[0], "%s.attr", dbfile);

apps/engine.c

+0 −5
Original line number Diff line number Diff line
@@ -148,11 +148,6 @@ static int util_flags(BIO *bio_out, unsigned int flags, const char *indent) 


	if(flags & ENGINE_CMD_FLAG_NUMERIC)

		{

		if(started)

			{

			BIO_printf(bio_out, "|");

			err = 1;

			}

		BIO_printf(bio_out, "NUMERIC");

		started = 1;

		}

apps/req.c

+0 −2
Original line number Diff line number Diff line
@@ -797,8 +797,6 @@ bad: 


		app_RAND_write_file(randfile, bio_err);



		if (pkey == NULL) goto end;



		if (keyout == NULL)

			{

			keyout=NCONF_get_string(req_conf,SECTION,KEYFILE);

apps/rsa.c

+1 −1
Original line number Diff line number Diff line
@@ -282,7 +282,7 @@ bad: 
				passin, e, "Private Key");



		if (pkey != NULL)

		rsa = pkey == NULL ? NULL : EVP_PKEY_get1_RSA(pkey);

			rsa = EVP_PKEY_get1_RSA(pkey);

		EVP_PKEY_free(pkey);

	}

apps/s_client.c

+1 −2
Original line number Diff line number Diff line
@@ -348,7 +348,7 @@ int MAIN(int, char **); 
int MAIN(int argc, char **argv)

	{

	int off=0;

	SSL *con=NULL,*con2=NULL;

	SSL *con=NULL;

	X509_STORE *store = NULL;

	int s,k,width,state=0;

	char *cbuf=NULL,*sbuf=NULL,*mbuf=NULL;
@@ -1239,7 +1239,6 @@ shut: 
end:

	if(prexit) print_stuff(bio_c_out,con,1);

	if (con != NULL) SSL_free(con);

	if (con2 != NULL) SSL_free(con2);

	if (ctx != NULL) SSL_CTX_free(ctx);

	if (cert)

		X509_free(cert);