Commit 6329b609 authored by Matt Caswell's avatar Matt Caswell
Browse files

Remove redundant check from tls1_get_curvelist 



The function tls1_get_curvelist() has an explicit check to see if s->cert
is NULL or not. However the check appears *after* calling the tls1_suiteb
macro which derefs s->cert. In reality s->cert can never be NULL because
it is created in SSL_new(). If the malloc fails then the SSL_new call fails
and no SSL object is created.

Reviewed-by: default avatarTim Hudson <tjh@openssl.org>
parent 55646005

ssl/t1_lib.c

+1 −1
Original line number Diff line number Diff line
@@ -441,7 +441,7 @@ static int tls1_get_curvelist(SSL *s, int sess, 
            pcurveslen = s->tlsext_ellipticcurvelist_length;

        }

        if (!*pcurves) {

            if (!s->server || (s->cert && s->cert->ecdh_tmp_auto)) {

            if (!s->server || s->cert->ecdh_tmp_auto) {

                *pcurves = eccurves_auto;

                pcurveslen = sizeof(eccurves_auto);

            } else {