Commit 6308af19 authored by Dr. Stephen Henson's avatar Dr. Stephen Henson
Browse files

Change PKCS#12 key derivation routines to cope with 

non null terminated passwords.
parent 8e5b6314

CHANGES

+6 −0
Changes for CHANGES: 6 added lines, 0 removed lines.
Original line number Diff line number Diff line
@@ -3,6 +3,12 @@ 


 Changes between 0.9.6 and 0.9.7  [xx XXX 2000]



  *) Change PKCS12_key_gen_asc() so it can cope with non null

     terminated strings whose length is passed in the passlen

     parameter, for example from PEM callbacks. This was done

     by adding an extra length parameter to asc2uni().

     [Steve Henson, reported by <oddissey@samsung.co.kr>]



  *) New OCSP utility. Allows OCSP requests to be generated or

     read. The request can be sent to a responder and the output

     parsed, outputed or printed in text form. Not complete yet:

crypto/pkcs12/p12_attr.c

+1 −1
Changes for crypto/pkcs12/p12_attr.c: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -151,7 +151,7 @@ int PKCS12_add_friendlyname_asc (PKCS12_SAFEBAG *bag, const char *name, 
{

	unsigned char *uniname;

	int ret, unilen;

	if (!asc2uni(name, &uniname, &unilen)) {

	if (!asc2uni(name, namelen, &uniname, &unilen)) {

		PKCS12err(PKCS12_F_PKCS12_ADD_FRIENDLYNAME_ASC,

							ERR_R_MALLOC_FAILURE);

		return 0;

crypto/pkcs12/p12_key.c

+1 −1
Changes for crypto/pkcs12/p12_key.c: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -84,7 +84,7 @@ int PKCS12_key_gen_asc(const char *pass, int passlen, unsigned char *salt, 
	if(!pass) {

		unipass = NULL;

		uniplen = 0;

	} else if (!asc2uni(pass, &unipass, &uniplen)) {

	} else if (!asc2uni(pass, passlen, &unipass, &uniplen)) {

		PKCS12err(PKCS12_F_PKCS12_KEY_GEN_ASC,ERR_R_MALLOC_FAILURE);

		return 0;

	}

crypto/pkcs12/p12_utl.c

+7 −3
Changes for crypto/pkcs12/p12_utl.c: 7 added lines, 3 removed lines.
Original line number Diff line number Diff line
@@ -62,16 +62,20 @@ 


/* Cheap and nasty Unicode stuff */



unsigned char *asc2uni (const char *asc, unsigned char **uni, int *unilen)

unsigned char *asc2uni(const char *asc, int asclen, unsigned char **uni, int *unilen)

{

	int ulen, i;

	unsigned char *unitmp;

	ulen = strlen(asc)*2  + 2;

	if (asclen == -1) asclen = strlen(asc);

	ulen = asclen*2  + 2;

	if (!(unitmp = OPENSSL_malloc(ulen))) return NULL;

	for (i = 0; i < ulen; i+=2) {

	for (i = 0; i < ulen - 2; i+=2) {

		unitmp[i] = 0;

		unitmp[i + 1] = asc[i>>1];

	}

	/* Make result double null terminated */

	unitmp[ulen - 2] = 0;

	unitmp[ulen - 1] = 0;

	if (unilen) *unilen = ulen;

	if (uni) *uni = unitmp;

	return unitmp;

crypto/pkcs12/pkcs12.h

+1 −1
Changes for crypto/pkcs12/pkcs12.h: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -230,7 +230,7 @@ int PKCS12_set_mac(PKCS12 *p12, const char *pass, int passlen, 
		   EVP_MD *md_type);

int PKCS12_setup_mac(PKCS12 *p12, int iter, unsigned char *salt,

					 int saltlen, EVP_MD *md_type);

unsigned char *asc2uni(const char *asc, unsigned char **uni, int *unilen);

unsigned char *asc2uni(const char *asc, int asclen, unsigned char **uni, int *unilen);

char *uni2asc(unsigned char *uni, int unilen);



DECLARE_ASN1_FUNCTIONS(PKCS12)