Commit 532203cd authored by Bodo Möller's avatar Bodo Möller
Browse files

remove unnecessary calls to EC_POINT_copy()

parent 870d3d55

crypto/ecdsa/ecs_key.c

+0 −2
Original line number Diff line number Diff line
@@ -92,7 +92,6 @@ int ECDSA_generate_key(ECDSA *ecdsa) 
	else

		pub_key = ecdsa->pub_key;



	if (!EC_POINT_copy(pub_key, EC_GROUP_get0_generator(ecdsa->group))) goto err;

	if (!EC_POINT_mul(ecdsa->group, pub_key, priv_key, NULL, NULL, ctx)) goto err;



	ecdsa->priv_key = priv_key;
@@ -130,7 +129,6 @@ int ECDSA_check_key(ECDSA *ecdsa) 
	if (ecdsa->priv_key)

	{

		if (BN_cmp(ecdsa->priv_key,order) >= 0) goto err;

		if (!EC_POINT_copy(point,EC_GROUP_get0_generator(ecdsa->group))) goto err;

		if (!EC_POINT_mul(ecdsa->group,point,ecdsa->priv_key,NULL,NULL,ctx)) goto err;

		if (EC_POINT_cmp(ecdsa->group,point,ecdsa->pub_key,ctx) != 0) goto err;

	}

crypto/ecdsa/ecs_ossl.c

+0 −10
Original line number Diff line number Diff line
@@ -159,11 +159,6 @@ static int ecdsa_sign_setup(ECDSA *ecdsa, BN_CTX *ctx_in, BIGNUM **kinvp, BIGNUM 
		reason = ERR_R_EC_LIB;

		goto err;

	}

	if (!EC_POINT_copy(tmp_point,EC_GROUP_get0_generator(ecdsa->group)))

	{

		reason = ERR_R_EC_LIB;

		goto err;

	}

	if (!EC_GROUP_get_order(ecdsa->group,order,ctx))

	{

		reason = ERR_R_EC_LIB;
@@ -355,11 +350,6 @@ static int ecdsa_do_verify(const unsigned char *dgst, int dgst_len, ECDSA_SIG *s 
		reason = ERR_R_EC_LIB;

		goto err;

	}

	if (!EC_POINT_copy(point,EC_GROUP_get0_generator(ecdsa->group)))

	{

		reason = ERR_R_EC_LIB;

		goto err;

	}

	if (!EC_POINT_mul(ecdsa->group,point,u1,ecdsa->pub_key,u2,ctx)

	    || !EC_POINT_get_affine_coordinates(ecdsa->group,point,X,NULL,ctx))

	{