Commit 47ae05ba authored by Cesar Pereida's avatar Cesar Pereida Committed by Matt Caswell
Browse files

Set flag BN_FLG_CONSTTIME earlier 



Reviewed-by: default avatarRich Salz <rsalz@openssl.org>
Reviewed-by: default avatarMatt Caswell <matt@openssl.org>
parent 033dc8fa

crypto/dsa/dsa_ossl.c

+2 −3
Original line number Diff line number Diff line
@@ -167,6 +167,8 @@ static int dsa_sign_setup(DSA *dsa, BN_CTX *ctx_in, 
            goto err;

    } while (BN_is_zero(k));



    BN_set_flags(k, BN_FLG_CONSTTIME);



    if (dsa->flags & DSA_FLAG_CACHE_MONT_P) {

        if (!BN_MONT_CTX_set_locked(&dsa->method_mont_p,

                                    dsa->lock, dsa->p, ctx))
@@ -189,8 +191,6 @@ static int dsa_sign_setup(DSA *dsa, BN_CTX *ctx_in, 
            goto err;

    }



    BN_set_flags(k, BN_FLG_CONSTTIME);



    if ((dsa)->meth->bn_mod_exp != NULL) {

            if (!dsa->meth->bn_mod_exp(dsa, r, dsa->g, k, dsa->p, ctx,

                                       dsa->method_mont_p))
@@ -200,7 +200,6 @@ static int dsa_sign_setup(DSA *dsa, BN_CTX *ctx_in, 
                goto err;

    }





    if (!BN_mod(r, r, dsa->q, ctx))

        goto err;