Commit 4336de0c authored Jun 05, 2015 by Dr. Stephen Henson

Check ASN1_INTEGER_get for errors.



Check return value when calling ASN1_INTEGER_get to retrieve a certificate
serial number. If an error occurs (which will be caused by the value being
out of range) revert to hex dump of serial number.

Reviewed-by: Rich Salz <rsalz@openssl.org>

parent c0cf5b84

crypto/asn1/t_x509.c

+7 −1

Original line number	Diff line number	Diff line
		@@ -141,7 +141,13 @@ int X509_print_ex(BIO bp, X509 x, unsigned long nmflags,

		bs = X509_get_serialNumber(x);
		if (bs->length <= (int)sizeof(long)) {
		ERR_set_mark();
		l = ASN1_INTEGER_get(bs);
		ERR_pop_to_mark();
		} else {
		l = -1;
		}
		if (l != -1) {
		if (bs->type == V_ASN1_NEG_INTEGER) {
		l = -l;
		neg = "-";