Commit 4162c7d3 authored by Matt Caswell's avatar Matt Caswell
Browse files

Fix mem leak on error path 



The mem pointed to by cAB can be leaked on an error path.

Reviewed-by: default avatarTim Hudson <tjh@openssl.org>
parent 85d6b09d

crypto/srp/srp_lib.c

+4 −2
Original line number Diff line number Diff line
@@ -168,7 +168,7 @@ BIGNUM *SRP_Calc_x(const BIGNUM *s, const char *user, const char *pass) 
{

    unsigned char dig[SHA_DIGEST_LENGTH];

    EVP_MD_CTX *ctxt;

    unsigned char *cs;

    unsigned char *cs = NULL;

    BIGNUM *res = NULL;



    if ((s == NULL) || (user == NULL) || (pass == NULL))
@@ -190,13 +190,15 @@ BIGNUM *SRP_Calc_x(const BIGNUM *s, const char *user, const char *pass) 
    BN_bn2bin(s, cs);

    if (!EVP_DigestUpdate(ctxt, cs, BN_num_bytes(s)))

        goto err;

    OPENSSL_free(cs);



    if (!EVP_DigestUpdate(ctxt, dig, sizeof(dig))

        || !EVP_DigestFinal_ex(ctxt, dig, NULL))

        goto err;



    res = BN_bin2bn(dig, sizeof(dig), NULL);



 err:

    OPENSSL_free(cs);

    EVP_MD_CTX_free(ctxt);

    return res;

}