Commit 3e0076c2 authored by Matt Caswell's avatar Matt Caswell
Browse files

Check md_size isn't negative before we use it 



Issue found by Coverity

Reviewed-by: default avatarAndy Polyakov <appro@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/6592)
parent c9d6fdd6

crypto/sm2/sm2_sign.c

+6 −5
Original line number Diff line number Diff line
@@ -25,16 +25,17 @@ static BIGNUM *sm2_compute_msg_hash(const EVP_MD *digest, 
{

    EVP_MD_CTX *hash = EVP_MD_CTX_new();

    const int md_size = EVP_MD_size(digest);

    uint8_t *za = OPENSSL_zalloc(md_size);

    uint8_t *za = NULL;

    BIGNUM *e = NULL;



    if (hash == NULL || za == NULL) {

        SM2err(SM2_F_SM2_COMPUTE_MSG_HASH, ERR_R_MALLOC_FAILURE);

    if (md_size < 0) {

        SM2err(SM2_F_SM2_COMPUTE_MSG_HASH, SM2_R_INVALID_DIGEST);

        goto done;

    }



    if (md_size < 0) {

        SM2err(SM2_F_SM2_COMPUTE_MSG_HASH, SM2_R_INVALID_DIGEST);

    za = OPENSSL_zalloc(md_size);

    if (hash == NULL || za == NULL) {

        SM2err(SM2_F_SM2_COMPUTE_MSG_HASH, ERR_R_MALLOC_FAILURE);

        goto done;

    }