Commit 349e6b2b authored by Jonas Maebe's avatar Jonas Maebe Committed by Kurt Roeckx
Browse files

cryptodev_digest_update: don't leak original state->mac_data if realloc fails 



Signed-off-by: default avatarKurt Roeckx <kurt@openssl.org>
Reviewed-by: default avatarRich Salz <rsalz@openssl.org>
parent 36f7ed50

crypto/engine/eng_cryptodev.c

+4 −2
Original line number Diff line number Diff line
@@ -765,6 +765,7 @@ static int cryptodev_digest_update(EVP_MD_CTX *ctx, const void *data, 
	struct crypt_op cryp;

	struct dev_crypto_state *state = ctx->md_data;

	struct session_op *sess = &state->d_sess;

	char *new_mac_data;



	if (!data || state->d_fd < 0) {

		printf("cryptodev_digest_update: illegal inputs \n");
@@ -777,12 +778,13 @@ static int cryptodev_digest_update(EVP_MD_CTX *ctx, const void *data, 


	if (!(ctx->flags & EVP_MD_CTX_FLAG_ONESHOT)) {

		/* if application doesn't support one buffer */

		state->mac_data = OPENSSL_realloc(state->mac_data, state->mac_len + count);

		new_mac_data = OPENSSL_realloc(state->mac_data, state->mac_len + count);



		if (!state->mac_data) {

		if (!new_mac_data) {

			printf("cryptodev_digest_update: realloc failed\n");

			return (0);

		}

		state->mac_data = new_mac_data;



		memcpy(state->mac_data + state->mac_len, data, count);

   		state->mac_len += count;