Commit 3173622e authored by Rich Salz's avatar Rich Salz
Browse files

RT2849: Redundant check of "dsa" variable. 



In the current code, the check isn't redundant.
And in fact the REAL check was missing.
This avoids a NULL-deref crash.

Reviewed-by: default avatarDr. Stephen Henson <steve@openssl.org>
parent 683cd7c9

fips/dsa/fips_dssvs.c

+6 −2
Original line number Diff line number Diff line
@@ -552,6 +552,11 @@ static void keypair(FILE *in, FILE *out) 
	    int n=atoi(value);



	    dsa = FIPS_dsa_new();

	    if (!dsa)

		{

		fprintf(stderr, "DSA allocation error\n");

		exit(1);

		}

	    if (!dsa2 && !dsa_builtin_paramgen(dsa, L, N, NULL, NULL, 0,

						NULL, NULL, NULL, NULL))

			{
@@ -578,7 +583,6 @@ static void keypair(FILE *in, FILE *out) 
		do_bn_print_name(out, "Y",dsa->pub_key);

	    	fputs(RESP_EOL, out);

		}

	    if (dsa)

	    FIPS_dsa_free(dsa);

	    }

	}