Commit 2647e261 authored by Matt Caswell's avatar Matt Caswell
Browse files

Remove repeated condition from if in X509_NAME_oneline 



An if checks the value of |type| to see if it is V_ASN1_VISIBLESTRING
twice. We only need to do it once.

GitHub Issue #656

Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
parent c0e32b16

crypto/x509/x509_obj.c

+1 −1
Original line number Diff line number Diff line
@@ -129,7 +129,7 @@ char *X509_NAME_oneline(X509_NAME *a, char *buf, int len) 
            type == V_ASN1_VISIBLESTRING ||

            type == V_ASN1_PRINTABLESTRING ||

            type == V_ASN1_TELETEXSTRING ||

            type == V_ASN1_VISIBLESTRING || type == V_ASN1_IA5STRING) {

            type == V_ASN1_IA5STRING) {

            if (num > (int)sizeof(ebcdic_buf))

                num = sizeof(ebcdic_buf);

            ascii2ebcdic(ebcdic_buf, q, num);