Commit 2338ad88 authored Aug 22, 2016 by David Benjamin Committed by Matt Caswell Aug 23, 2016

Fix math in BN_bn2dec comment.



The bound on log(2)/3 on the second line is incorrect and has an extra
zero compared to the divisions in the third line. log(2)/3 = 0.10034...
which is bounded by 0.101 and not 0.1001. The divisions actually
correspond to 0.101 which is fine. The third line also dropped a factor
of three.

The actual code appears to be fine. Just the comments are wrong.

Reviewed-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>

parent fa515410

crypto/bn/bn_print.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -67,8 +67,8 @@ char BN_bn2dec(const BIGNUM a)
		/*-
		* get an upper bound for the length of the decimal integer
		* num <= (BN_num_bits(a) + 1) * log(2)
		* <= 3 * BN_num_bits(a) * 0.1001 + log(2) + 1 (rounding error)
		* <= BN_num_bits(a)/10 + BN_num_bits/1000 + 1 + 1
		* <= 3 * BN_num_bits(a) * 0.101 + log(2) + 1 (rounding error)
		* <= 3 * BN_num_bits(a) / 10 + 3 * BN_num_bits / 1000 + 1 + 1
		*/
		i = BN_num_bits(a) * 3;
		num = (i / 10 + i / 1000 + 1) + 1;