Commit 1421aead authored by Richard J. Moore's avatar Richard J. Moore Committed by Rich Salz
Browse files

Make some more X509 functions const. 



Reviewed-by: default avatarStephen Henson <steve@openssl.org>
Reviewed-by: default avatarRich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/1367)
parent e5452d40

apps/ca.c

+3 −3
Original line number Diff line number Diff line
@@ -980,14 +980,14 @@ end_of_options: 
        if (verbose)

            BIO_printf(bio_err, "writing new certificates\n");

        for (i = 0; i < sk_X509_num(cert_sk); i++) {

            ASN1_INTEGER *serialNumber = X509_get_serialNumber(x);

            const ASN1_INTEGER *serialNumber = X509_get_serialNumber(x);

            int k;

            char *n;



            x = sk_X509_value(cert_sk, i);



            j = ASN1_STRING_length(serialNumber);

            p = (const char *)ASN1_STRING_data(serialNumber);

            p = (const char *)ASN1_STRING_data((ASN1_INTEGER *)serialNumber);



            if (strlen(outdir) >= (size_t)(j ? BSIZE - j * 2 - 6 : BSIZE - 8)) {

                BIO_printf(bio_err, "certificate file name too long\n");
@@ -1685,7 +1685,7 @@ static int do_body(X509 **xret, EVP_PKEY *pkey, X509 *x509, 
        goto end;

#endif



    if (BN_to_ASN1_INTEGER(serial, X509_get_serialNumber(ret)) == NULL)

    if (BN_to_ASN1_INTEGER(serial, (ASN1_INTEGER *)X509_get_serialNumber(ret)) == NULL)

        goto end;

    if (selfsign) {

        if (!X509_set_issuer_name(ret, subject))

crypto/ocsp/ocsp_lib.c

+2 −2
Original line number Diff line number Diff line
@@ -22,7 +22,7 @@ 
OCSP_CERTID *OCSP_cert_to_id(const EVP_MD *dgst, X509 *subject, X509 *issuer)

{

    X509_NAME *iname;

    ASN1_INTEGER *serial;

    const ASN1_INTEGER *serial;

    ASN1_BIT_STRING *ikey;

    if (!dgst)

        dgst = EVP_sha1();
@@ -40,7 +40,7 @@ OCSP_CERTID *OCSP_cert_to_id(const EVP_MD *dgst, X509 *subject, X509 *issuer) 
OCSP_CERTID *OCSP_cert_id_new(const EVP_MD *dgst,

                              X509_NAME *issuerName,

                              ASN1_BIT_STRING *issuerKey,

                              ASN1_INTEGER *serialNumber)

                              const ASN1_INTEGER *serialNumber)

{

    int nid;

    unsigned int i;

crypto/x509/x509_cmp.c

+3 −3
Original line number Diff line number Diff line
@@ -80,7 +80,7 @@ int X509_CRL_match(const X509_CRL *a, const X509_CRL *b) 
    return memcmp(a->sha1_hash, b->sha1_hash, 20);

}



X509_NAME *X509_get_issuer_name(X509 *a)

X509_NAME *X509_get_issuer_name(const X509 *a)

{

    return (a->cert_info.issuer);

}
@@ -97,12 +97,12 @@ unsigned long X509_issuer_name_hash_old(X509 *x) 
}

#endif



X509_NAME *X509_get_subject_name(X509 *a)

X509_NAME *X509_get_subject_name(const X509 *a)

{

    return (a->cert_info.subject);

}



ASN1_INTEGER *X509_get_serialNumber(X509 *a)

const ASN1_INTEGER *X509_get_serialNumber(const X509 *a)

{

    return &a->cert_info.serialNumber;

}

crypto/x509/x509_set.c

+3 −3
Original line number Diff line number Diff line
@@ -110,17 +110,17 @@ int X509_up_ref(X509 *x) 
    return ((i > 1) ? 1 : 0);

}



long X509_get_version(X509 *x)

long X509_get_version(const X509 *x)

{

    return ASN1_INTEGER_get(x->cert_info.version);

}



ASN1_TIME * X509_get_notBefore(X509 *x)

ASN1_TIME * X509_get_notBefore(const X509 *x)

{

    return x->cert_info.validity.notBefore;

}



ASN1_TIME *X509_get_notAfter(X509 *x)

ASN1_TIME *X509_get_notAfter(const X509 *x)

{

    return x->cert_info.validity.notAfter;

}

include/openssl/ocsp.h

+1 −1
Original line number Diff line number Diff line
@@ -187,7 +187,7 @@ OCSP_CERTID *OCSP_cert_to_id(const EVP_MD *dgst, X509 *subject, X509 *issuer); 
OCSP_CERTID *OCSP_cert_id_new(const EVP_MD *dgst,

                              X509_NAME *issuerName,

                              ASN1_BIT_STRING *issuerKey,

                              ASN1_INTEGER *serialNumber);

                              const ASN1_INTEGER *serialNumber);



OCSP_ONEREQ *OCSP_request_add0_id(OCSP_REQUEST *req, OCSP_CERTID *cid);