Commit 05bdebb6 authored by Matt Caswell's avatar Matt Caswell
Browse files

Fix off-by-one error in BN_bn2hex 



A BIGNUM can have the value of -0. The function BN_bn2hex fails to account
for this and can allocate a buffer one byte too short in the event of -0
being used, leading to a one byte buffer overrun. All usage within the
OpenSSL library is considered safe. Any security risk is considered
negligible.

With thanks to Mateusz Kocielski (LogicalTrust), Marek Kroemeke and
Filip Palian for discovering and reporting this issue.

Reviewed-by: default avatarTim Hudson <tjh@openssl.org>
(cherry picked from commit c5635307)

Conflicts:
	crypto/bn/bn_print.c
parent 32b2ad7e

crypto/bn/bn_print.c

+6 −1
Original line number Diff line number Diff line
@@ -71,7 +71,12 @@ char *BN_bn2hex(const BIGNUM *a) 
    char *buf;

    char *p;



    buf = (char *)OPENSSL_malloc(a->top * BN_BYTES * 2 + 2);

    if (a->neg && BN_is_zero(a)) {

        /* "-0" == 3 bytes including NULL terminator */

        buf = OPENSSL_malloc(3);

    } else {

        buf = OPENSSL_malloc(a->top * BN_BYTES * 2 + 2);

    }

    if (buf == NULL) {

        BNerr(BN_F_BN_BN2HEX, ERR_R_MALLOC_FAILURE);

        goto err;