Commit ed429b72 authored by Daniel Stenberg's avatar Daniel Stenberg
Browse files

gtls: add check of return code 

Coverity CID 1291167 pointed out that 'rc' was received but never used when
gnutls_credentials_set() was used. Added return code check now.
parent fea13a17

lib/vtls/gtls.c

+9 −1
Original line number Diff line number Diff line
@@ -671,13 +671,21 @@ gtls_connect_step1(struct connectdata *conn, 
  if(data->set.ssl.authtype == CURL_TLSAUTH_SRP) {

    rc = gnutls_credentials_set(session, GNUTLS_CRD_SRP,

                                conn->ssl[sockindex].srp_client_cred);

    if(rc != GNUTLS_E_SUCCESS)

    if(rc != GNUTLS_E_SUCCESS) {

      failf(data, "gnutls_credentials_set() failed: %s", gnutls_strerror(rc));

      return CURLE_SSL_CONNECT_ERROR;

    }

  }

  else

#endif

  {

    rc = gnutls_credentials_set(session, GNUTLS_CRD_CERTIFICATE,

                                conn->ssl[sockindex].cred);

    if(rc != GNUTLS_E_SUCCESS) {

      failf(data, "gnutls_credentials_set() failed: %s", gnutls_strerror(rc));

      return CURLE_SSL_CONNECT_ERROR;

    }

  }



  /* set the connection handle (file descriptor for the socket) */

  gnutls_transport_set_ptr(session,