Unverified Commit e407e79c authored by Daniel Stenberg's avatar Daniel Stenberg
Browse files

http: add missing return code check 

Detected by Coverity. CID 1439610.

Follow-up from 46e16406

Closes #3034
parent 30b2d07b

lib/http.c

+3 −6
Original line number Diff line number Diff line
@@ -2453,8 +2453,6 @@ CURLcode Curl_http(struct connectdata *conn, bool *done) 
  if(conn->bits.httpproxy && !conn->bits.tunnel_proxy) {

    char *url = data->change.url;

    result = Curl_add_buffer(&req_buffer, url, strlen(url));

    if(result)

      return result;

  }

  else if(paste_ftp_userpwd)

    result = Curl_add_bufferf(&req_buffer, "ftp://%s:%s@%s",
@@ -2464,12 +2462,11 @@ CURLcode Curl_http(struct connectdata *conn, bool *done) 
    result = Curl_add_buffer(&req_buffer, path, strlen(path));

    if(result)

      return result;

    if(query) {

    if(query)

      result = Curl_add_bufferf(&req_buffer, "?%s", query);

  }

  if(result)

    return result;

    }

  }



  result =

    Curl_add_bufferf(&req_buffer,