- Jeff Pohlmeyer identified two problems: first a rather obscure problem with (cbf58d88) · Commits · CYBER - Cyber Security / TS 103 523 MSP / TLMSP / TLMSP curl

CHANGES

+9 −0

Original line number	Diff line number	Diff line
		@@ -6,6 +6,15 @@

		Changelog

		Daniel (18 February 2007)
		- Jeff Pohlmeyer identified two problems: first a rather obscure problem with
		the multi interface and connection re-use that could make a
		curl_multi_remove_handle() ruin a pointer in another handle.

		The second problem was less of an actual problem but more of minor quirk:
		the re-using of connections wasn't properly checking if the connection was
		marked for closure.

		Daniel (16 February 2007)
		- Duncan Mac-Vicar Prett and Michal Marek reported problems with resetting
		CURLOPT_RANGE back to no range on an easy handle when using FTP.

+3 −1

Original line number	Diff line number	Diff line
		@@ -23,6 +23,7 @@ This release includes the following bugfixes:
		o socks5 works
		o builds fine with VC2005
		o CURLOPT_RANGE set to NULL resets the range for FTP
		o curl_multi_remove_handle() rare crash

		This release includes the following known bugs:

		@@ -40,6 +41,7 @@ This release would not have looked like this without help, code, reports and
		advice from friends like these:

		Yang Tse, Manfred Schwarb, Michael Wallner, Jeff Pohlmeyer, Shmulik Regev,
		Rob Crittenden, Robert A. Monat, Duncan Mac-Vicar Prett, Michal Marek
		Rob Crittenden, Robert A. Monat, Dan Fandrich, Duncan Mac-Vicar Prett,
		Michal Marek

		Thanks! (and sorry if I forgot to mention someone)

+0 −3

Original line number	Diff line number	Diff line
		@@ -7,9 +7,6 @@ may have been fixed since this was written!
		--ftp-ssl-ccc on some servers. Recipe and instructions here:
		http://curl.haxx.se/mail/lib-2007-01/0210.html

		41. Jeff Pohlmeyer's curl_multi_socket crashing case. Recipe and instructions
		here: http://curl.haxx.se/mail/lib-2007-01/0022.html

		40. HTTP Pipelining, NULL content
		http://curl.haxx.se/bug/view.cgi?id=1631566

+4 −3

Original line number	Diff line number	Diff line
		@@ -1403,6 +1403,10 @@ CURLcode Curl_http_connect(struct connectdata conn, bool done)

		data=conn->data;

		/* We default to persistent connections. We set this already in this connect
		function to make the re-use checks properly be able to check this bit. */
		conn->bits.close = FALSE;

		/* If we are not using a proxy and we want a secure connection, perform SSL
		* initialization & connection now. If using a proxy with https, then we
		* must tell the proxy to CONNECT to the host we want to talk to. Only
		@@ -1674,9 +1678,6 @@ CURLcode Curl_http(struct connectdata conn, bool done)
		else
		http = data->reqdata.proto.http;

		/* We default to persistent connections */
		conn->bits.close = FALSE;

		if ( (conn->protocol&(PROT_HTTP\|PROT_FTP)) &&
		data->set.upload) {
		httpreq = HTTPREQ_PUT;

+4 −5

Original line number	Diff line number	Diff line
		@@ -542,11 +542,10 @@ CURLMcode curl_multi_remove_handle(CURLM *multi_handle,
		easy->easy_handle->dns.hostcachetype = HCACHE_NONE;
		}

		/* if we have a connection we must call Curl_done() here so that we
		don't leave a half-baked one around */
		if(easy->easy_conn) {
		/* Set up the association right */
		easy->easy_conn->data = easy->easy_handle;
		/* we must call Curl_done() here (if we still "own it") so that we don't
		leave a half-baked one around */
		if(easy->easy_conn &&
		(easy->easy_conn->data == easy->easy_handle)) {

		/* Curl_done() clears the conn->data field to lose the association
		between the easy handle and the connection */