Commit c79f4908 authored by Daniel Stenberg's avatar Daniel Stenberg
Browse files

krb5: use private buffer for temp string, not receive buffer

parent 89cf6f38

lib/krb5.c

+9 −5
Original line number Original line Diff line number Diff line
@@ -164,6 +164,7 @@ krb5_auth(void *app_data, struct connectdata *conn) 
  size_t base64_sz = 0;

  size_t base64_sz = 0;

  struct sockaddr_in **remote_addr =

  struct sockaddr_in **remote_addr =

    (struct sockaddr_in **)&conn->ip_addr->ai_addr;

    (struct sockaddr_in **)&conn->ip_addr->ai_addr;

  char *stringp;





  if(getsockname(conn->sock[FIRSTSOCKET],

  if(getsockname(conn->sock[FIRSTSOCKET],

                 (struct sockaddr *)&conn->local_addr, &l) < 0)

                 (struct sockaddr *)&conn->local_addr, &l) < 0)
@@ -193,16 +194,19 @@ krb5_auth(void *app_data, struct connectdata *conn) 
        return -1;

        return -1;

    }

    }





    input_buffer.value = data->state.buffer;

    stringp = aprintf("%s@%s", service, host);

    input_buffer.length = snprintf(input_buffer.value, BUFSIZE, "%s@%s",

    if(!stringp)

                                   service, host);

      return -2;



    input_buffer.value = stringp;

    input_buffer.length = strlen(stringp);

    maj = gss_import_name(&min, &input_buffer, GSS_C_NT_HOSTBASED_SERVICE,

    maj = gss_import_name(&min, &input_buffer, GSS_C_NT_HOSTBASED_SERVICE,

                          &gssname);

                          &gssname);

    free(stringp);

    if(maj != GSS_S_COMPLETE) {

    if(maj != GSS_S_COMPLETE) {

      gss_release_name(&min, &gssname);

      gss_release_name(&min, &gssname);

      if(service == srv_host) {

      if(service == srv_host) {

        Curl_failf(data, "Error importing service name %s",

        Curl_failf(data, "Error importing service name %s@%s", service, host);

                   input_buffer.value);

        return AUTH_ERROR;

        return AUTH_ERROR;

      }

      }

      service = srv_host;

      service = srv_host;