Unverified Commit c36f4283 authored by Daniel Stenberg's avatar Daniel Stenberg
Browse files

singlesocket: use separate variable for inner loop 

An inner loop within the singlesocket() function wrongly re-used the
variable for the outer loop which then could cause an infinite
loop. Change to using a separate variable!

Reported-by: Eric Wu
Fixes #3970
Closes #3973
parent d3d04a87

lib/multi.c

+4 −4
Original line number Diff line number Diff line
@@ -2252,14 +2252,14 @@ static CURLMcode singlesocket(struct Curl_multi *multi, 
    actions[i] = action;

    if(entry) {

      /* check if new for this transfer */

      for(i = 0; i< data->numsocks; i++) {

        if(s == data->sockets[i]) {

          prevaction = data->actions[i];

      int j;

      for(j = 0; j< data->numsocks; j++) {

        if(s == data->sockets[j]) {

          prevaction = data->actions[j];

          sincebefore = TRUE;

          break;

        }

      }



    }

    else {

      /* this is a socket we didn't have before, add it to the hash! */