Commit c341311a authored by Daniel Stenberg's avatar Daniel Stenberg
Browse files

Revert "cleanup: general removal of TODO (and similar) comments" 

This reverts commit 64e959ff.

Feedback-by: Dan Fandrich
URL: http://curl.haxx.se/mail/lib-2015-11/0062.html
parent fc5d7835

lib/asyn-ares.c

+1 −0
Original line number Diff line number Diff line
@@ -416,6 +416,7 @@ CURLcode Curl_resolver_wait_resolv(struct connectdata *conn, 
  if(result)

    /* close the connection, since we can't return failure here without

       cleaning up this connection properly.

       TODO: remove this action from here, it is not a name resolver decision.

    */

    connclose(conn, "c-ares resolve failed");

lib/curl_memory.h

+2 −2
Original line number Diff line number Diff line
@@ -7,7 +7,7 @@ 
 *                            | (__| |_| |  _ <| |___

 *                             \___|\___/|_| \_\_____|

 *

 * Copyright (C) 1998 - 2015, Daniel Stenberg, <daniel@haxx.se>, et al.

 * Copyright (C) 1998 - 2013, Daniel Stenberg, <daniel@haxx.se>, et al.

 *

 * This software is licensed as described in the file COPYING, which

 * you should have received as part of this distribution. The terms
@@ -39,7 +39,7 @@ 
 *

 * File lib/strdup.c is an exception, given that it provides a strdup

 * clone implementation while using malloc. Extra care needed inside

 * this one.

 * this one. TODO: revisit this paragraph and related code.

 *

 * The need for curl_memory.h inclusion is due to libcurl's feature

 * of allowing library user to provide memory replacement functions,

lib/easy.c

+1 −1
Original line number Diff line number Diff line
@@ -646,7 +646,7 @@ static CURLcode wait_or_timeout(struct Curl_multi *multi, struct events *ev) 
      return CURLE_RECV_ERROR;



    if(mcode)

      return CURLE_URL_MALFORMAT;

      return CURLE_URL_MALFORMAT; /* TODO: return a proper error! */



    /* we don't really care about the "msgs_in_queue" value returned in the

       second argument */

lib/ftp.c

+1 −1
Original line number Diff line number Diff line
@@ -3659,7 +3659,7 @@ static CURLcode ftp_do_more(struct connectdata *conn, int *completep) 
  if(!conn->bits.tcpconnect[SECONDARYSOCKET]) {

    if(conn->tunnel_state[SECONDARYSOCKET] == TUNNEL_CONNECT) {

      /* As we're in TUNNEL_CONNECT state now, we know the proxy name and port

         aren't used so we blank their arguments. */

         aren't used so we blank their arguments. TODO: make this nicer */

      result = Curl_proxyCONNECT(conn, SECONDARYSOCKET, NULL, 0, FALSE);



      return result;

lib/http.c

+6 −1
Original line number Diff line number Diff line
@@ -2047,7 +2047,10 @@ CURLcode Curl_http(struct connectdata *conn, bool *done) 
      ptr = strstr(url, conn->host.dispname);

      if(ptr) {

        /* This is where the display name starts in the URL, now replace this

           part with the encoded name. */

           part with the encoded name. TODO: This method of replacing the host

           name is rather crude as I believe there's a slight risk that the

           user has entered a user name or password that contain the host name

           string. */

        size_t currlen = strlen(conn->host.dispname);

        size_t newlen = strlen(conn->host.name);

        size_t urllen = strlen(url);
@@ -3329,6 +3332,7 @@ CURLcode Curl_http_readwrite_headers(struct SessionHandle *data, 
          conn->httpversion = 11; /* For us, RTSP acts like HTTP 1.1 */

        }

        else {

          /* TODO: do we care about the other cases here? */

          nc = 0;

        }

      }
@@ -3559,6 +3563,7 @@ CURLcode Curl_http_readwrite_headers(struct SessionHandle *data, 
        }



        if(k->auto_decoding)

          /* TODO: we only support the first mentioned compression for now */

          break;



        if(checkprefix("identity", start)) {