Commit a89a211e authored by Tatsuhiro Tsujikawa's avatar Tatsuhiro Tsujikawa Committed by Jay Satiro
Browse files

http2: Don't increment drain when one header field is received 

Sicne we write header field in temporary location, not in the memory
that upper layer provides, incrementing drain should not happen.

Ref: https://github.com/curl/curl/issues/659
Ref: https://github.com/curl/curl/pull/663
parent 86c633a8

lib/http2.c

+0 −4
Original line number Diff line number Diff line
@@ -848,8 +848,6 @@ static int on_header(nghttp2_session *session, const nghttp2_frame *frame, 
    Curl_add_buffer(stream->header_recvbuf, value, valuelen);

    /* the space character after the status code is mandatory */

    Curl_add_buffer(stream->header_recvbuf, " \r\n", 3);

    data_s->state.drain++;

    conn->proto.httpc.drain_total++;

    /* if we receive data for another handle, wake that up */

    if(conn->data != data_s)

      Curl_expire(data_s, 1);
@@ -866,8 +864,6 @@ static int on_header(nghttp2_session *session, const nghttp2_frame *frame, 
  Curl_add_buffer(stream->header_recvbuf, ":", 1);

  Curl_add_buffer(stream->header_recvbuf, value, valuelen);

  Curl_add_buffer(stream->header_recvbuf, "\r\n", 2);

  data_s->state.drain++;

  conn->proto.httpc.drain_total++;

  /* if we receive data for another handle, wake that up */

  if(conn->data != data_s)

    Curl_expire(data_s, 1);