Unverified Commit 892c5e4c authored Jun 04, 2017 by Marcel Raad

curl_ntlm_core: pass unsigned char to toupper

Otherwise, clang on Cygwin64 warns:
curl_ntlm_core.c:525:35: error: array subscript is of type 'char'
[-Werror,-Wchar-subscripts]
    dest[2 * i] = (unsigned char)(toupper(src[i]));
                                  ^~~~~~~~~~~~~~~
/usr/include/ctype.h:152:25: note: expanded from macro 'toupper'
      (void) __CTYPE_PTR[__x]; (toupper) (__x);})
                        ^~~~

parent 65ba9265

lib/curl_ntlm_core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -522,7 +522,7 @@ static void ascii_uppercase_to_unicode_le(unsigned char *dest,
		{
		size_t i;
		for(i = 0; i < srclen; i++) {
		dest[2 * i] = (unsigned char)(toupper(src[i]));
		dest[2 * i] = (unsigned char)(toupper((unsigned char)src[i]));
		dest[2 * i + 1] = '\0';
		}
		}