Commit 7d48d851 authored by Dan Fandrich's avatar Dan Fandrich
Browse files

Fixed a memory leak and improper shutdown on SFTP post-quote command failure.

parent 6a2cecf1

lib/ssh.c

+3 −5
Original line number Diff line number Diff line
@@ -949,6 +949,7 @@ CURLcode Curl_sftp_done(struct connectdata *conn, CURLcode status, 
                        bool premature)

{

  struct SSHPROTO *sftp = conn->data->reqdata.proto.ssh;

  CURLcode rc = CURLE_OK;

  (void)premature; /* not used */



  Curl_safefree(sftp->path);
@@ -959,10 +960,7 @@ CURLcode Curl_sftp_done(struct connectdata *conn, CURLcode status, 


  /* Before we shut down, see if there are any post-quote commands to send: */

  if(!status && !premature && conn->data->set.postquote) {

    CURLcode result = sftp_sendquote(conn, conn->data->set.postquote);



    if (result != CURLE_OK)

      return result;

    rc = sftp_sendquote(conn, conn->data->set.postquote);

  }



  if (sftp->sftp_handle) {
@@ -995,7 +993,7 @@ CURLcode Curl_sftp_done(struct connectdata *conn, CURLcode status, 


  (void)status; /* unused */



  return CURLE_OK;

  return rc;

}



/* return number of received (decrypted) bytes */