Unverified Commit 7c5837e7 authored by Daniel Stenberg's avatar Daniel Stenberg
Browse files

CURLOPT_DNS_USE_GLOBAL_CACHE: deprecated 

Disable the CURLOPT_DNS_USE_GLOBAL_CACHE option and mark it for
deprecation and complete removal in six months.

Bug: https://curl.haxx.se/mail/lib-2018-09/0010.html
Closes #2942
parent 25fd1057

docs/DEPRECATE.md

+21 −0
Original line number Diff line number Diff line
@@ -70,3 +70,24 @@ libcurl code. 
Left to answer: should the *setopt() function start to return error when these

options are set to be able to tell when they're trying to use options that are

no longer around or should we maintain behavior as much as possible?



## CURLOPT_DNS_USE_GLOBAL_CACHE



This option makes libcurl use a global non-thread-safe cache for DNS if

enabled. The option has been marked as "obsolete" in the header file and in

documentation for several years already.



There's proper and safe method alternative provided since many years: the

share API.



### State



In curl 7.62.0 setting this option to TRUE will not have any effect. The

global cache will not be enabled. The code still remains so it is easy to

revert if need be.



### Removal



Remove all global-cache related code from curl around April 2019 (might be

7.66.0).

lib/setopt.c

+2 −0
Original line number Diff line number Diff line
@@ -127,9 +127,11 @@ CURLcode Curl_vsetopt(struct Curl_easy *data, CURLoption option, 
    data->set.dns_cache_timeout = arg;

    break;

  case CURLOPT_DNS_USE_GLOBAL_CACHE:

#if 0 /* deprecated */

    /* remember we want this enabled */

    arg = va_arg(param, long);

    data->set.global_dns_cache = (0 != arg) ? TRUE : FALSE;

#endif

    break;

  case CURLOPT_SSL_CIPHER_LIST:

    /* set a list of cipher we want to use in the SSL connection */