Immanuel Gregoire fixed KNOWN_BUGS #44: --ftp-method nocwd did not handle

                                  Changelog

Daniel S (24 September 2007)

- Immanuel Gregoire fixed KNOWN_BUGS #44: --ftp-method nocwd did not handle

  URLs ending with a slash properly (it should list the contents of that

  directory). Test case 351 brought back and also test 1010 was added.

Daniel S (21 September 2007)

- Mark Davies fixed Negotiate authentication over proxy, and also introduced

  the --proxy-negotiate command line option to allow a user to explicitly

 o ldap builds with the MSVC makefiles

 o no HOME and no key given caused SSH auth failure

 o Negotiate authentication over proxy

 o --ftp-method nocwd on directory listings

This release includes the following known bugs:

  initial suggested function to use for randomizing the response:

    http://curl.haxx.se/mail/lib-2007-07/0178.html

44. --ftp-method nocwd does not handle URLs ending with a slash properly (it

  should list the contents of that directory). See test case 351.

43. There seems to be a problem when connecting to the Microsoft telnet server.

  http://curl.haxx.se/bug/view.cgi?id=1720605

     way. It has turned out that the NLST list output is not the same on all

     servers either... */

  NBFTPSENDF(conn, "%s",

  /*

     if FTPFILE_NOCWD was specified, we are currently in

     the user's home directory, so we should add the path

     as argument for the LIST / NLST / or custom command.

     Whether the server will support this, is uncertain.

     The other ftp_filemethods will CWD into dir/dir/ first and

     then just do LIST (in that case: nothing to do here)

  */

  char *cmd,*lstArg,*slashPos;

  lstArg = NULL;

  if((data->set.ftp_filemethod == FTPFILE_NOCWD) &&

     data->reqdata.path &&

     data->reqdata.path[0] &&

     strchr(data->reqdata.path,'/')) {

    lstArg = strdup(data->reqdata.path);

    if(!lstArg)

      return CURLE_OUT_OF_MEMORY;

    /* Check if path does not end with /, as then we cut off the file part */

    if(lstArg[strlen(lstArg) - 1] != '/')  {

      /* chop off the file part if format is dir/dir/file */

      slashPos = strrchr(lstArg,'/');

      *(slashPos+1) = '\0';

    }

  }

  cmd = aprintf( "%s%s%s",

                 data->set.str[STRING_CUSTOMREQUEST]?

                 data->set.str[STRING_CUSTOMREQUEST]:

             (data->set.ftp_list_only?"NLST":"LIST"));

                 (data->set.ftp_list_only?"NLST":"LIST"),

                 lstArg? " ": "",

                 lstArg? lstArg: "" );

  if(!cmd)

    return CURLE_OUT_OF_MEMORY;

  NBFTPSENDF(conn, "%s",cmd);

  if(lstArg)

    free(lstArg);

  free(cmd);

  state(conn, FTP_LIST);

    size_t flen = ftp->file?strlen(ftp->file):0; /* file is "raw" already */

    size_t dlen = strlen(path)-flen;

    if(!ftpc->cwdfail) {

      if(dlen) {

      if(dlen && (data->set.ftp_filemethod != FTPFILE_NOCWD)) {

        ftpc->prevpath = path;

        if(flen)

          /* if 'path' is not the whole string */

  switch(data->set.ftp_filemethod) {

  case FTPFILE_NOCWD:

    /* fastest, but less standard-compliant */

    /*

      The best time to check whether the path is a file or directory is right

      here. so:

      the first condition in the if() right here, is there just in case

      someone decides to set path to NULL one day

   */

    if(data->reqdata.path &&

       data->reqdata.path[0] &&

       (data->reqdata.path[strlen(data->reqdata.path) - 1] != '/') )

      ftp->file = data->reqdata.path;  /* this is a full file path */

    else

      ftp->file = NULL;

      /*

        ftp->file is not used anywhere other than for operations on a file.

        In other words, never for directory operations.

        So we can safely set it to NULL here and use it as a

        argument in dir/file decisions.

      */

    break;

  case FTPFILE_SINGLECWD:

# per line.

# Lines starting with '#' letters are treated as comments.

#230

351