Commit 5ea3d2ff authored by Daniel Stenberg's avatar Daniel Stenberg
Browse files

checksrc: improve the fopen() parser somewhat 

The quote scanner was too fragile, now look for a comma instead to find
the mode argument.
parent d4d87d7e

lib/checksrc.pl

+5 −5
Original line number Diff line number Diff line
@@ -6,7 +6,7 @@ 
#                            | (__| |_| |  _ <| |___

#                             \___|\___/|_| \_\_____|

#

# Copyright (C) 2011 - 2015, Daniel Stenberg, <daniel@haxx.se>, et al.

# Copyright (C) 2011 - 2016, Daniel Stenberg, <daniel@haxx.se>, et al.

#

# This software is licensed as described in the file COPYING, which

# you should have received as part of this distribution. The terms
@@ -234,11 +234,11 @@ sub scanfile { 
        }



        # scan for use of non-binary fopen without the macro

        if($l =~ /^(.*\W)fopen\s*\([^"]*\"([^"]*)/) {

        if($l =~ /^(.*\W)fopen\s*\([^,]*, *\"([^"]*)/) {

            my $mode = $2;

            if($mode !~ /b/) {

                checkwarn($line, length($1), $file, $l,

                          "use of non-binary fopen without FOPEN_* macro");

                          "use of non-binary fopen without FOPEN_* macro: $mode");

            }

        }