Unverified Commit 59813726 authored by Daniel Stenberg's avatar Daniel Stenberg
Browse files

checksrc: detect and warn for multiple spaces

parent 20acb58a

lib/checksrc.pl

+13 −0
Original line number Diff line number Diff line
@@ -62,6 +62,7 @@ my %warnings = ( 
    'EQUALSNOSPACE'    => 'equals sign without following space',

    'NOSPACEEQUALS'    => 'equals sign without preceeding space',

    'SEMINOSPACE'      => 'semicolon without following space',

    'MULTISPACE'       => 'multiple spaces used when not suitable',

    );



sub readwhitelist {
@@ -563,6 +564,18 @@ sub scanfile { 
                      "no space after semilcolon");

        }



        # check for more than one consecutive space before open brace or

        # question mark. Skip lines containing strings since they make it hard

        # due to artificially getting multiple spaces

        if(($l eq $nostr) &&

           $nostr =~ /^(.*(\S)) + [{?]/i) {

            checkwarn("MULTISPACE",

                      $line, length($1)+1, $file, $ol,

                      "multiple space");

            print STDERR "L: $l\n";

            print STDERR "nostr: $nostr\n";

        }



        $line++;

        $prevl = $ol;

    }